Skip to content

Doc fixes #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 38 commits into from
Sep 19, 2017
Merged

Doc fixes #690

merged 38 commits into from
Sep 19, 2017

Conversation

fredericDelaporte
Copy link
Member

No description provided.

There is a known issue where some SQL Server 2005 notifications might not be received when an
application subscribes to query notifications by using ADO.NET 2.0. To fix this problem install
<ulink url="http://support.microsoft.com/Default.aspx?kbid=913364">SQL hotfix for kb 913364</ulink>.
</para>
Copy link
Member Author

@fredericDelaporte fredericDelaporte Sep 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link dead, kb not found anymore, probably merged in a SQL 2005 SP since long.

The second level cache requires the use of transactions, be it through transaction scopes or NHibernate
transactions. Interacting with the data store without an explicit transaction is discouraged, and will
not allow the second level cache to work as intended.
</para>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One frequent cause of complains about second level cache not working.

</formalpara>
<para>
See also <xref linkend="performance-cache" />.
</para>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have two separated section documenting second level cache, each with valuable information not available in the other. It would be better to merge them. At least I add a cross link here. (The other side already does it.)

@fredericDelaporte
Copy link
Member Author

fredericDelaporte commented Sep 17, 2017

Building SHFB was failing due to two reasons:

The file NHibernate.ndoc.in references another missing property (project.version.short), but it does not seems to cause issues. Is this file an obsolete artifact? I do not find any reference to it.

@fredericDelaporte fredericDelaporte changed the title Doc fixes - proxy factory unneeded by default, second level cache Doc fixes Sep 17, 2017
@fredericDelaporte
Copy link
Member Author

fredericDelaporte commented Sep 18, 2017

The doc was referring to a bunch of non existent methods, like ISession.Find, ISession.Enumerable, ISession.Filter which were likely short-hands for creating queries/filters and executing them. I have replaced them. And done many other fixes and modernizations.

@fredericDelaporte fredericDelaporte added this to the 5.0 milestone Sep 19, 2017
@fredericDelaporte fredericDelaporte merged commit 623d798 into nhibernate:master Sep 19, 2017
@fredericDelaporte fredericDelaporte deleted the doc-fixes branch September 19, 2017 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants