NH-3927 - Switch to SemVer version generation #674
Conversation
hazzik
commented
Aug 15, 2017
hazzik
commented
- SharedAssemblyInfo.?? are retired
hazzik
force-pushed
the
NH-3927
branch
2 times, most recently
from
48a2b27 to
98d148a
Compare
hazzik
requested review from
fredericDelaporte
and removed request for
fredericDelaporte
| @@ -1,24 +1,17 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
| <Import Project="../../build-common/NHibernate.props" /> | |||
There was a problem hiding this comment.
Move the Description from the AssemblyInfo.cs like the rest of the projects.
| @@ -1,24 +1,17 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
| <Import Project="../../build-common/NHibernate.props" /> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFramework>net461</TargetFramework> | |||
| <OutputType>Exe</OutputType> | |||
| <StartupObject>NHibernate.Tool.HbmXsd.Program</StartupObject> | |||
| <GenerateAssemblyTitleAttribute>False</GenerateAssemblyTitleAttribute> | |||
There was a problem hiding this comment.
Remove these AssemblyInfo generation blockers like the rest of the projects.
build-common/NHibernate.props
Outdated
| <VersionMajor Condition="'$(VersionMajor)' == ''">5</VersionMajor> | ||
| <VersionMinor Condition="'$(VersionMinor)' == ''">0</VersionMinor> | ||
| <VersionPatch Condition="'$(VersionPatch)' == ''">0</VersionPatch> | ||
| <VersionSuffix>Alpha1</VersionSuffix> |
There was a problem hiding this comment.
This should be <VersionSuffix Condition="'$(VersionSuffix)' == ''">Alpha1</VersionSuffix> so it can be overwritten at build time.
|
Is using the Team City build number in scope for this issue? Versioning per-build, or at least per pull-request, so that when building the release packages per pull request the resulting NuGet package versions from the TeamCity CI are separated out and usable. The logical branch name is available as |
Not yet. |
- SharedAssemblyInfo.?? are retired
|
@ngbrown did not know you have approval rights:) thanks |
|
I just wanted to acknowledge that you made the changes I suggested. I don't really have rejection/approval rights. That's why my check mark is grayed out. Edit: I guess it actually depends on if you have "Require review from Code Owners" checked. |
|
I just didn't know that it's possible:) |
