Skip to content

Fix limits in polymorphic queries #2618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 14, 2021
Merged

Conversation

csharper2010
Copy link
Contributor

@csharper2010 csharper2010 commented Nov 24, 2020

Results from the query should be skipped if they are already in the ISet distinction thus if distinction.Add is false. Currently, they are only added if they have been there before.

Fixes #2614

Results from the query should be skipped if they are already in the
ISet distinction thus if distinction.Add is false. Currently, they are
only added if they have been there before.

Signed-off-by: csharper2010
@hazzik
Copy link
Member

hazzik commented Nov 24, 2020

Need tests to prevent future regressions.

Polymorphic query with limit
to resolve codefactor issue
@hazzik hazzik added the t: Fix label Dec 17, 2020
@hazzik hazzik added this to the next minor milestone Dec 17, 2020
@hazzik hazzik changed the title Fixes nhibernate#2614 Fix limits in polymorphic queries Dec 17, 2020
@hazzik hazzik merged commit 2b1af8f into nhibernate:master Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Obvious bug in two HQLQueryPlan classes with distinction Set
3 participants