Skip to content

Fix some HQL functions registration #1535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 20, 2018
Merged

Fix some HQL functions registration #1535

merged 5 commits into from
Jan 20, 2018

Conversation

fredericDelaporte
Copy link
Member

@fredericDelaporte fredericDelaporte commented Jan 17, 2018 •
edited
Loading

  • ceiling was not registered for Oracle, while it needs to be transcripted to ceil
  • ceil was registered as ceil for SQL-Server, which only supports ceiling
  • chr was wrongly registered as chr for SQL-Server, it needs to be registered as char
  • More registrations of ascii, chr, floor, ceiling, ceil
  • Fix type registrations for ceiling, floor, chr, ascii in Firebird
  • Fix registrations of chr in MySql
  • Fixes NH-3804 - Register CHR/CHAR, NCHAR, UNICODE, and ASCII standard functions to the dialect(s) #837
  • Consolidate function support test logic in Test project

@fredericDelaporte fredericDelaporte mentioned this pull request Jan 17, 2018
Merged
7 tasks
@fredericDelaporte
Fix some HQL functions registration
3a26ff9 
 * ceiling was not registered for Oracle, while it needs to be transcripted to ceil
 * ceil was registered as ceil for SQL-Server, which only supports ceiling
 * chr was wrongly registered as chr for SQL-Server, it needs to be registered as char
@fredericDelaporte
Copy link
Member Author

The two last commits have been done as options for taking into account @hazzik comment. They may be both dropped if preferring the current situation (which has its reasons, as explained in my reply). Or the last commit may be dropped, if preferring not changing other tests by the way.

@fredericDelaporte fredericDelaporte added this to the 5.1 milestone Jan 20, 2018
@fredericDelaporte fredericDelaporte merged commit 083a928 into nhibernate:master Jan 20, 2018
@fredericDelaporte fredericDelaporte deleted the HqlFunctions branch January 20, 2018 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hazzik hazzik hazzik approved these changes

Assignees
No one assigned
Labels
c: DataProviders / Dialects p: Minor r: Fixed t: Bug
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
2 participants
@fredericDelaporte @hazzik