Fix some HQL functions registration

 * ceiling was not registered for Oracle, while it needs to be transcripted to ceil
 * ceil was registered as ceil for SQL-Server, which only supports ceiling
 * chr was wrongly registered as chr for SQL-Server, it needs to be registered as char

Author: fredericDelaporte

src/NHibernate.Test/Async/Hql/HQLFunctions.cs

@@ -75,6 +75,7 @@ protected override void OnTearDown()
 			{
 				s.Delete("from Human");
 				s.Delete("from Animal");
+				s.Delete("from MaterialResource");
 				s.Flush();
 			}
 		}
@@ -531,6 +532,28 @@ public async Task AbsAsync()
 			}
 		}
 
+		[Test]
+		public async Task CeilingAsync()
+		{
+			using (var s = OpenSession())
+			{
+				var a1 = new Animal("a1", 1.3f);
+				await (s.SaveAsync(a1));
+				await (s.FlushAsync());
+			}
+			using (var s = OpenSession())
+			{
+				var ceiling = await (s.CreateQuery("select ceiling(a.BodyWeight) from Animal a").UniqueResultAsync<float>());
+				Assert.That(ceiling, Is.EqualTo(2));
+				var count =
+					await (s
+						.CreateQuery("select count(*) from Animal a where ceiling(a.BodyWeight) = :c")
+						.SetInt32("c", 2)
+						.UniqueResultAsync<long>());
+				Assert.That(count, Is.EqualTo(1));
+			}
+		}
+
 		[Test]
 		public async Task ModAsync()
 		{
@@ -637,6 +660,28 @@ public async Task LowerAsync()
 			}
 		}
 
+		[Test]
+		public async Task ChrAsync()
+		{
+			using (var s = OpenSession())
+			{
+				var m = new MaterialResource("Blah", "000", (MaterialResource.MaterialState)32);
+				await (s.SaveAsync(m));
+				await (s.FlushAsync());
+			}
+			using (var s = OpenSession())
+			{
+				var space = await (s.CreateQuery("select chr(m.State) from MaterialResource m").UniqueResultAsync<char>());
+				Assert.That(space, Is.EqualTo(' '));
+				var count =
+					await (s
+						.CreateQuery("select count(*) from MaterialResource m where chr(m.State) = :c")
+						.SetCharacter("c", ' ')
+						.UniqueResultAsync<long>());
+				Assert.That(count, Is.EqualTo(1));
+			}
+		}
+
 		[Test]
 		public async Task CastAsync()
 		{

src/NHibernate.Test/Hql/HQLFunctions.cs

@@ -64,6 +64,7 @@ protected override void OnTearDown()
 			{
 				s.Delete("from Human");
 				s.Delete("from Animal");
+				s.Delete("from MaterialResource");
 				s.Flush();
 			}
 		}
@@ -520,6 +521,28 @@ public void Abs()
 			}
 		}
 
+		[Test]
+		public void Ceiling()
+		{
+			using (var s = OpenSession())
+			{
+				var a1 = new Animal("a1", 1.3f);
+				s.Save(a1);
+				s.Flush();
+			}
+			using (var s = OpenSession())
+			{
+				var ceiling = s.CreateQuery("select ceiling(a.BodyWeight) from Animal a").UniqueResult<float>();
+				Assert.That(ceiling, Is.EqualTo(2));
+				var count =
+					s
+						.CreateQuery("select count(*) from Animal a where ceiling(a.BodyWeight) = :c")
+						.SetInt32("c", 2)
+						.UniqueResult<long>();
+				Assert.That(count, Is.EqualTo(1));
+			}
+		}
+
 		[Test]
 		public void Mod()
 		{
@@ -626,6 +649,28 @@ public void Lower()
 			}
 		}
 
+		[Test]
+		public void Chr()
+		{
+			using (var s = OpenSession())
+			{
+				var m = new MaterialResource("Blah", "000", (MaterialResource.MaterialState)32);
+				s.Save(m);
+				s.Flush();
+			}
+			using (var s = OpenSession())
+			{
+				var space = s.CreateQuery("select chr(m.State) from MaterialResource m").UniqueResult<char>();
+				Assert.That(space, Is.EqualTo(' '));
+				var count =
+					s
+						.CreateQuery("select count(*) from MaterialResource m where chr(m.State) = :c")
+						.SetCharacter("c", ' ')
+						.UniqueResult<long>();
+				Assert.That(count, Is.EqualTo(1));
+			}
+		}
+
 		[Test]
 		public void Cast()
 		{

src/NHibernate/Dialect/MsSql2000Dialect.cs

@@ -284,7 +284,7 @@ protected virtual void RegisterFunctions()
 			RegisterFunction("sign", new StandardSQLFunction("sign", NHibernateUtil.Int32));
 
 			RegisterFunction("ceiling", new StandardSQLFunction("ceiling"));
-			RegisterFunction("ceil", new StandardSQLFunction("ceil"));
+			RegisterFunction("ceil", new StandardSQLFunction("ceiling"));
 			RegisterFunction("floor", new StandardSQLFunction("floor"));
 			RegisterFunction("round", new StandardSQLFunction("round"));
 
@@ -326,7 +326,7 @@ protected virtual void RegisterFunctions()
 			RegisterFunction("date", new SQLFunctionTemplate(NHibernateUtil.Date, "dateadd(dd, 0, datediff(dd, 0, ?1))"));
 			RegisterFunction("concat", new VarArgsSQLFunction(NHibernateUtil.String, "(", "+", ")"));
 			RegisterFunction("digits", new StandardSQLFunction("digits", NHibernateUtil.String));
-			RegisterFunction("chr", new StandardSQLFunction("chr", NHibernateUtil.Character));
+			RegisterFunction("chr", new StandardSQLFunction("char", NHibernateUtil.Character));
 			RegisterFunction("upper", new StandardSQLFunction("upper"));
 			RegisterFunction("ucase", new StandardSQLFunction("ucase"));
 			RegisterFunction("lcase", new StandardSQLFunction("lcase"));

src/NHibernate/Dialect/Oracle8iDialect.cs

@@ -230,6 +230,7 @@ protected virtual void RegisterFunctions()
 			RegisterFunction("round", new StandardSQLFunction("round"));
 			RegisterFunction("trunc", new StandardSQLFunction("trunc"));
 			RegisterFunction("ceil", new StandardSQLFunction("ceil"));
+			RegisterFunction("ceiling", new StandardSQLFunction("ceil"));
 			RegisterFunction("floor", new StandardSQLFunction("floor"));
 
 			RegisterFunction("chr", new StandardSQLFunction("chr", NHibernateUtil.Character));

src/NHibernate/Dialect/OracleLiteDialect.cs

@@ -69,6 +69,7 @@ public OracleLiteDialect()
 			RegisterFunction("round", new StandardSQLFunction("round"));
 			RegisterFunction("trunc", new StandardSQLFunction("trunc"));
 			RegisterFunction("ceil", new StandardSQLFunction("ceil"));
+			RegisterFunction("ceiling", new StandardSQLFunction("ceil"));
 			RegisterFunction("floor", new StandardSQLFunction("floor"));
 
 			RegisterFunction("chr", new StandardSQLFunction("chr", NHibernateUtil.Character));