Skip to content

Update call-out shortcode usage in Contributing #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 13, 2025
Merged

Conversation

lamATnginx
Copy link
Contributor

@lamATnginx lamATnginx commented Mar 13, 2025

Proposed changes

Update CONTRIBUTING_DOCS.md for new usage of call-out shortcode. See below for output:

Before:
Screenshot 2025-03-13 at 10 33 09 AM

After:
Screenshot 2025-03-13 at 10 33 38 AM

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

@lamATnginx lamATnginx added the documentation Improvements or additions to documentation label Mar 13, 2025
@lamATnginx lamATnginx self-assigned this Mar 13, 2025
@lamATnginx lamATnginx requested a review from a team as a code owner March 13, 2025 17:28
@github-actions github-actions bot added the process documentation Documentation related to how the repository or documention itself is managed. label Mar 13, 2025
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/286/

Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one suggested change

Co-authored-by: Mike Jang <3287976+mjang@users.noreply.github.com>
@lamATnginx lamATnginx enabled auto-merge (squash) March 13, 2025 18:02
@lamATnginx lamATnginx merged commit b78bff7 into main Mar 13, 2025
5 checks passed
@lamATnginx lamATnginx deleted the chore/update-ct branch March 13, 2025 18:02
travisamartin pushed a commit that referenced this pull request Mar 13, 2025
* chore: Update call-out shortcode usage in Contributing

* Update with suggestion

Co-authored-by: Mike Jang <3287976+mjang@users.noreply.github.com>

---------

Co-authored-by: Mike Jang <3287976+mjang@users.noreply.github.com>
travisamartin added a commit that referenced this pull request Mar 19, 2025
…#287)

* Removed unnecessary metadata keys and standardized the remaining ones

* Update call-out shortcode usage in Contributing (#286)

* chore: Update call-out shortcode usage in Contributing

* Update with suggestion

Co-authored-by: Mike Jang <3287976+mjang@users.noreply.github.com>

---------

Co-authored-by: Mike Jang <3287976+mjang@users.noreply.github.com>

* removed extra blank line after front matter block

* edits

* Update content/controller/admin-guides/install/resilient-cluster-aws.md

Co-authored-by: Jon Torre <78599298+JTorreG@users.noreply.github.com>

* Update content/mesh/about/mesh-tech-specs.md

* fixed types that had blank values

* removed null from empty descriptions

* removed ' character from weight key

* removed trial links that weren't correct

---------

Co-authored-by: Lam <150060045+lamATnginx@users.noreply.github.com>
Co-authored-by: Mike Jang <3287976+mjang@users.noreply.github.com>
Co-authored-by: Jon Torre <78599298+JTorreG@users.noreply.github.com>
Co-authored-by: Alan Dooley <a.dooley@f5.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation process documentation Documentation related to how the repository or documention itself is managed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants