This repository was archived by the owner on May 10, 2021. It is now read-only.
Fix broken redirects (#45) #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a test for #45
Use the NextJS code for sorting routes (instead of @sls-next's code): - /node_modules/next/dist/next-server/lib/router/utils/sorted-routes - https://github.com/vercel/next.js/blob/canary/packages/next/ next-server/lib/router/utils/sorted-routes.ts The regex for removing file endings used in /lib/helpers/getSortedRoutes was incorrect and led to incorrect route paths being passed into the sorting function. This has been fixed.
Remove two unused require-statements from /lib/pages/getStaticProps/redirects.js. These are leftover from refactoring.
lindsaylevine
approved these changes
Oct 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the refactoring last week, I accidentally introduced two bugs into the redirects generated by
next-on-netlify. One bug caused invalid rewrites to be generated when having an optional catch-all route at top-level (e.g., /pages/[[...slug]].js). The other bug caused the rewrites to be in the incorrect order, leading to catch-all routes preceding more specific, static routes.This fixes #45.
📣 Shoutout to @lindsaylevine for pair-programming and fixing this together! ✨