Broken redirects with optional catch-all route at top-level in pages/

[amuttsch]

What's wrong

With version 2.4.0 yarn run build produces the following (correct) out_publish/_redirects file:

# Next-on-Netlify Redirects
/api  /.netlify/functions/next_api  200
*  /.netlify/functions/next_any  200

Using 2.5.0 the sorting has changed, and the catch all rules are before the specific ones:

# Next-on-Netlify Redirects
/*  /.netlify/functions/next_any  200
  /.netlify/functions/next_any  200
/api  /.netlify/functions/next_api  200

We can see the /* catch route is before the /api route. Additionally, there is a new (and possible invalid) redirect.

Now the requests to /api are routed to / and the specific handler is not called.

How to reproduce

I created a minimal example repo here: https://github.com/amuttsch/next-on-netlify-minimal

To reproduce just change the version of next-on-netlify in the package.json to 2.4.0 or 2.5.0 and run yarn install && yarn run build.

Thanks for your work on this package!

[FinnWoelm]

Hey @amuttsch, thanks for filing this issue and for your detailed report!

This one is totally my bad! 😬 🙈 Looks like I missed this scenario when we did a major refactor last week. You have an optional catch-all route at pages/ top-level, is that right? @lindsaylevine and I will fix this tonight and make sure to add a test, so it doesn't happen again in the future!

We'll keep you posted!

[amuttsch]

Hi Finn,

yes I do have a root level catch all route, it also happens if I have a separate index.jsx and a [any.jsx] file.

Thanks for your quick reply, I'm looking forward for the fix :-)

[FinnWoelm]

Turns out that I actually introduced not just one, but two bugs during the refactoring! 😬 But I think we got it figured out and #47 will fix that 🙌 🙌

If you're in a hurry, you can already try out the new code by running npm install netlify/next-on-netlify#fix-broken-redirects. Otherwise, I think we'll get this reviewed, merged, and deployed shortly 🙂

[FinnWoelm]

Hi @amuttsch, this issue should be resolved now 😊 🔥 Let us know if you have any more trouble and thanks again for reporting!

[amuttsch]

The fix looks good, thanks for the quick response! :-)