-
-
Notifications
You must be signed in to change notification settings - Fork 5
Improve min max performance and IEEE compliance #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve min max performance and IEEE compliance #151
Conversation
Look like the build failure is because the firmware changes need to be merged first. |
For reference: Before...
After...
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Impressive! Thanks for all the work on this.
Great usage of the benchmark library! 😉
Overall all good. We're better moving the Max and Min to mscorlib.
Even if that's not release rigth away. It won't break anything.
Description
Motivation and Context
Math.Max(float)
andMath.Min(float)
are 3x slower than thedouble
overloads Home#1395Math.Min(double/float)
do not handle NaN correctly Home#1396How Has This Been Tested?
Screenshots
Types of changes
Checklist: