Skip to content

Switching MathInternal.Min/Max to managed implementations #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

CoryCharlton
Copy link
Member

@CoryCharlton CoryCharlton commented Nov 6, 2023

Description

  • Switching min/max to managed implementations in MathInternal

Motivation and Context

How Has This Been Tested?

  • On device
  • Unit tests

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

@josesimoes josesimoes changed the title Switching min/max to managed implementations in MathInternal Switching MathInternal.Min/Max to managed implementations Nov 6, 2023
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josesimoes josesimoes added ⚠️ DO NOT MERGE ⚠️ This is not to be merged. In doubt check with the person that put the label. and removed Status: in progress labels Nov 7, 2023
@josesimoes josesimoes removed the ⚠️ DO NOT MERGE ⚠️ This is not to be merged. In doubt check with the person that put the label. label Nov 9, 2023
@josesimoes josesimoes merged commit a09ff54 into nanoframework:main Nov 9, 2023
@CoryCharlton CoryCharlton deleted the improve_min_max_internal branch November 9, 2023 03:33
josesimoes pushed a commit that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants