Update core library to add support for generics <T> #242
Conversation
***NO_CI***
…nto generics-wip
***NO_CI***
***NO_CI***
- Add new libraries to list of repos to update. ***NO_CI***
…nds (#207) ***NO_CI***
***NO_CI***
- Add new class libraries to update list. ***NO_CI***
- Improve conditions for update dependents. ***NO_CI***
- Improve conditions for update dependents. ***NO_CI***
- Rework variable declaration to include sign group. ***NO_CI***
***NO_CI***
***NO_CI***
josesimoes
changed the title
…nto generics-wip
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
azure-pipelines.yml (1)
63-64: Local override for DOTNET_NOLOGO with minor formatting issue.Adding the
DOTNET_NOLOGOvariable in the Build_mscorlib job’s variables explicitly ensures that the setting is applied at the job level. However, there are trailing spaces on line 64 that should be removed to satisfy YAML linting standards.
Suggested change:- - name: DOTNET_NOLOGO - value: true + - name: DOTNET_NOLOGO + value: true🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 64-64: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (7)
Tests/NFUnitTestSystemLib/UnitTestInitLocalTests.csis excluded by none and included by noneTests/NFUnitTestSystemLib/UnitTestReflectionTypeTest.csis excluded by none and included by noneTests/NFUnitTest_DummyAdapter/nano.runsettingsis excluded by none and included by noneTests/UnitTestLauncher/UnitTestLauncher.nfprojis excluded by none and included by nonenanoFramework.CoreLibrary/System/AssemblyInfo.csis excluded by none and included by nonenanoFramework.CoreLibrary/System/Reflection/AssemblyNameFlags.csis excluded by none and included by nonenanoFramework.TestFrameworkis excluded by none and included by none
📒 Files selected for processing (2)
azure-pipelines.yml(3 hunks)version.json(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
azure-pipelines.yml
[error] 64-64: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: nanoframework.CoreLibrary (Build_mscorlib)
🔇 Additional comments (4)
version.json (2)
3-3: Version bump update is correct.The version field has been updated from "1.17" to "2.0", which aligns with the major release and the intended breaking change for generics support.
8-10: Verify semVer value type.The
"semVer"field is now set to a numeric value (2.0) rather than a string. Please confirm that this change conforms with the schema and does not cause downstream parsing issues.azure-pipelines.yml (2)
166-168: Ensuring proper job dependency.The addition of the
dependsOn: - Build_mscorlibin the Update_Dependents job ensures that dependent updates run only after a successful build of mscorlib, which is crucial for maintaining build integrity.
195-195: Inclusion of new dependent repository.The addition of the
nanoframework.System.Runtimerepository to the list of repositories for the Update_Dependents job ensures that updates for support related to generics are correctly propagated. Please ensure that corresponding documentation is updated to reflect this inclusion.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
azure-pipelines.yml (2)
63-64: Remove Trailing Whitespace in DOTNET_NOLOGO Setting
There are trailing spaces at the end of thevalue: trueline (line 64). Please remove these to satisfy YAML linting standards.- value: true + value: true🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 64-64: trailing spaces
(trailing-spaces)
63-64: Clarify the Scope of DOTNET_NOLOGO Definition
The variableDOTNET_NOLOGOis already declared globally in lines 39–44, and it is being re-declared in the Build_mscorlib job (lines 63–64). If the duplicate declaration is intentional (for a job-specific override), please add a clarifying comment. Otherwise, consider consolidating the declaration to avoid redundancy.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 64-64: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (7)
.runsettingsis excluded by none and included by nonenanoFramework.CoreLibrary/System/Convert.csis excluded by none and included by nonenanoFramework.CoreLibrary/System/DateTime.csis excluded by none and included by nonenanoFramework.CoreLibrary/System/DayOfWeek.csis excluded by none and included by nonenanoFramework.CoreLibrary/System/Guid.csis excluded by none and included by nonenanoFramework.CoreLibrary/System/IO/IOException.csis excluded by none and included by nonenanoFramework.CoreLibrary/System/Reflection/MemberTypes.csis excluded by none and included by none
📒 Files selected for processing (1)
azure-pipelines.yml(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
azure-pipelines.yml
[error] 64-64: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: nanoframework.CoreLibrary (Build_mscorlib)
…nto generics-wip
…nto generics-wip
…nto generics-wip
- Add generics branch to nbgv config. ***NO_CI***
- Add generics branh to pipeline trigger. ***NO_CI***
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
azure-pipelines.yml (1)
64-65: Remove Trailing Whitespace in DOTNET_NOLOGO Variable Definition
There are trailing spaces on line 65 which could trigger YAML linting issues. Please remove the extra spaces. Additionally, note thatDOTNET_NOLOGOis defined both globally (lines 41–42) and at the job level. If the duplication is intentional for overriding purposes, no further action is required beyond cleaning up the whitespace; otherwise, consider consolidating the definition to avoid redundancy.Diff suggestion:
- value: true + value: true🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 65-65: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
azure-pipelines.yml(2 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
azure-pipelines.yml
[error] 65-65: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: nanoframework.CoreLibrary (Build_mscorlib)
🔇 Additional comments (1)
azure-pipelines.yml (1)
10-10: Generics Branch Pattern Added Successfully
Adding the- generics*branch pattern to the trigger section is a precise way to ensure that branches supporting generics are built automatically. This aligns with the PR objective to update the core library for generics support.
- Config usage of preview VS extension.
|
Unit tests failing as expected. |
|
josesimoes
removed
the
⚠️ DO NOT MERGE ⚠️
Description
Motivation and Context
How Has This Been Tested?
Screenshots
Types of changes
Checklist:
Summary by CodeRabbit
New Features
Chores
generics*.