chore(ci): test on windows [3.6] #2634
Conversation
…windows-evergreen
test/functional/cursor.test.js
Outdated
| @@ -2346,7 +2351,7 @@ describe('Cursor', function() { | |||
| test.equal(null, err); | |||
|
|
|||
| if (id === 99) { | |||
| setTimeout(() => client.close()); | |||
| setTimeout(() => client.close(validator)); | |||
There was a problem hiding this comment.
This looks like a bug to me. validator is incrementing the close count and is meant to do so in response to the stream closing, not the client. This is short circuiting that, and likely ending the test before confirming that the stream has indeed closed (or errored)
There was a problem hiding this comment.
I made this change because the test was timing out; IIRC I tried passing done in instead of validator, but then was getting "done called twice" errors. I can take another look at this one.
| metadata: { | ||
| requires: { topology: ['single', 'replicaset', 'sharded', 'ssl', 'heap', 'wiredtiger'] } | ||
| }, | ||
| metadata: { requires: { os: '!win32' } }, // leaks on windows |
There was a problem hiding this comment.
Can you make a ticket to track all of these tests which "leak on windows", and leave a reference to them in the code where the tests are skipped? This means that streams, or cursors (or both) are kind of broken on windows. Someone should look into that relatively soon
Description
Run the test suite on Windows in Evergreen for the
3.6branch.patch build
NODE-1458
What changed?
.evergreen/install-dependencies.shwas updated to use nvm-windows instead of nvm when running in Windows environments.os: '!win32'metadata directive..mdfiles 🏎️currently, when a test run leaks resources it sits idle until reaching our 15 minute global evergreen task timeout and being killed. This PR adds a 60 second per-task idle timeout to the driver test run on evergreen, so if a test run finishes after 5 minutes but leaks resources, the task will finish due to the idle timeout in 6 minutes rather than 15 minutes.
Are there any files to ignore?