chore(ci): skip broken windows tests, idle timeout, colors #2629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emadum
changed the title
emadum
changed the title
emadum
changed the title
emadum
changed the title
nbbeeken
reviewed
Nov 24, 2020
| @@ -1475,7 +1475,7 @@ describe('Change Streams', function() { | |||
| } | |||
| }); | |||
|
|
|||
| it('should resume piping of Change Streams when a resumable error is encountered', { | |||
| it.skip('should resume piping of Change Streams when a resumable error is encountered', { | |||
There was a problem hiding this comment.
Is this a sometimes leaky test?
There was a problem hiding this comment.
It was leaking the '_nodemongodbnative_resumepipe.txt' resource at some point in my testing, but I forget exactly when/where. I'll unskip to check if it's still an issue.
emadum
changed the title
emadum
changed the base branch from
3.6
to
NODE-1458/3.6/support-windows-evergreen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed in favor of #2634