-
Notifications
You must be signed in to change notification settings - Fork 178
RUST-1859 Sync bulk write spec tests #1106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
isabelatkinson
merged 7 commits into
mongodb:main
from
isabelatkinson:sync-bulk-write-tests
May 17, 2024
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7123f86
sync crud
isabelatkinson 73762df
sync transactions
isabelatkinson 7d33304
sync retryable writes
isabelatkinson 3b4c41c
sync command logging and monitoring
isabelatkinson 848e641
sync server selection
isabelatkinson 300c24b
sync versioned api
isabelatkinson de3c7c8
remove bulk write unified
isabelatkinson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,7 +8,6 @@ use crate::{ | |
test::{ | ||
get_client_options, | ||
log_uncaptured, | ||
spec::unified_runner::run_unified_tests, | ||
util::fail_point::{FailPoint, FailPointMode}, | ||
}, | ||
Client, | ||
|
@@ -40,14 +39,6 @@ impl PartialBulkWriteResult { | |
} | ||
} | ||
|
||
#[tokio::test(flavor = "multi_thread")] | ||
async fn run_unified() { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These are now run in |
||
run_unified_tests(&["crud", "unified", "new-bulk-write"]) | ||
// TODO RUST-1405: unskip this test | ||
.skip_files(&["client-bulkWrite-errorResponse.json"]) | ||
.await; | ||
} | ||
|
||
// CRUD prose test 3 | ||
#[tokio::test] | ||
async fn max_write_batch_size_batching() { | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caught by a retryable writes test, we were adding duplicates here upon retry