RUST-1859 Sync bulk write spec tests #1106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isabelatkinson
commented
May 16, 2024
| @@ -57,6 +57,8 @@ impl<'a> OperationWithDefaults for Insert<'a> { | |||
| const NAME: &'static str = "insert"; | |||
|
|
|||
| fn build(&mut self, description: &StreamDescription) -> Result<Command<Self::Command>> { | |||
| self.inserted_ids.clear(); | |||
There was a problem hiding this comment.
Caught by a retryable writes test, we were adding duplicates here upon retry
src/operation/distinct.rs
Outdated
| }; | ||
|
|
||
| if !self.query.is_empty() { | ||
| body.insert("query", self.query.clone()); |
There was a problem hiding this comment.
One of the new crud tests expects this field to be present even if the query is empty
| @@ -40,14 +39,6 @@ impl PartialBulkWriteResult { | |||
| } | |||
| } | |||
|
|
|||
| #[tokio::test(flavor = "multi_thread")] | |||
| async fn run_unified() { | |||
There was a problem hiding this comment.
These are now run in crud::run_unified
abr-egn
approved these changes
May 17, 2024
isabelatkinson
force-pushed
the
sync-bulk-write-tests
branch
from
643931e to
de3c7c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also pulls in some unified test conversions (RUST-1866, RUST-1863).