-
Notifications
You must be signed in to change notification settings - Fork 1.1k
PYTHON-5079 Convert test.test_dns to async #2096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
67c8a85
WIP
sleepyStick a0693d9
connect to db
sleepyStick e62b3f5
okay idk why it wanted to change it last time only to undo it this time
sleepyStick 83faeea
Merge branch 'master' into PYTHON-5079
sleepyStick b5f6db0
use helper methods to create client
sleepyStick 6fd0ce0
Merge branch 'master' into PYTHON-5079
sleepyStick 02df48e
Merge branch 'master' into PYTHON-5079
sleepyStick File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,222 @@ | ||
# Copyright 2017 MongoDB, Inc. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
"""Run the SRV support tests.""" | ||
from __future__ import annotations | ||
|
||
import glob | ||
import json | ||
import os | ||
import pathlib | ||
import sys | ||
|
||
sys.path[0:0] = [""] | ||
|
||
from test.asynchronous import ( | ||
AsyncIntegrationTest, | ||
AsyncPyMongoTestCase, | ||
async_client_context, | ||
unittest, | ||
) | ||
from test.utils import async_wait_until | ||
|
||
from pymongo.common import validate_read_preference_tags | ||
from pymongo.errors import ConfigurationError | ||
from pymongo.uri_parser import parse_uri, split_hosts | ||
|
||
_IS_SYNC = False | ||
|
||
|
||
class TestDNSRepl(AsyncPyMongoTestCase): | ||
if _IS_SYNC: | ||
TEST_PATH = os.path.join( | ||
pathlib.Path(__file__).resolve().parent, "srv_seedlist", "replica-set" | ||
) | ||
else: | ||
TEST_PATH = os.path.join( | ||
pathlib.Path(__file__).resolve().parent.parent, "srv_seedlist", "replica-set" | ||
) | ||
load_balanced = False | ||
|
||
@async_client_context.require_replica_set | ||
def asyncSetUp(self): | ||
pass | ||
|
||
|
||
class TestDNSLoadBalanced(AsyncPyMongoTestCase): | ||
if _IS_SYNC: | ||
TEST_PATH = os.path.join( | ||
pathlib.Path(__file__).resolve().parent, "srv_seedlist", "load-balanced" | ||
) | ||
else: | ||
TEST_PATH = os.path.join( | ||
pathlib.Path(__file__).resolve().parent.parent, "srv_seedlist", "load-balanced" | ||
) | ||
load_balanced = True | ||
|
||
@async_client_context.require_load_balancer | ||
def asyncSetUp(self): | ||
pass | ||
|
||
|
||
class TestDNSSharded(AsyncPyMongoTestCase): | ||
if _IS_SYNC: | ||
TEST_PATH = os.path.join(pathlib.Path(__file__).resolve().parent, "srv_seedlist", "sharded") | ||
else: | ||
TEST_PATH = os.path.join( | ||
pathlib.Path(__file__).resolve().parent.parent, "srv_seedlist", "sharded" | ||
) | ||
load_balanced = False | ||
|
||
@async_client_context.require_mongos | ||
def asyncSetUp(self): | ||
pass | ||
|
||
|
||
def create_test(test_case): | ||
async def run_test(self): | ||
uri = test_case["uri"] | ||
seeds = test_case.get("seeds") | ||
num_seeds = test_case.get("numSeeds", len(seeds or [])) | ||
hosts = test_case.get("hosts") | ||
num_hosts = test_case.get("numHosts", len(hosts or [])) | ||
|
||
options = test_case.get("options", {}) | ||
if "ssl" in options: | ||
options["tls"] = options.pop("ssl") | ||
parsed_options = test_case.get("parsed_options") | ||
# See DRIVERS-1324, unless tls is explicitly set to False we need TLS. | ||
needs_tls = not (options and (options.get("ssl") is False or options.get("tls") is False)) | ||
if needs_tls and not async_client_context.tls: | ||
self.skipTest("this test requires a TLS cluster") | ||
if not needs_tls and async_client_context.tls: | ||
self.skipTest("this test requires a non-TLS cluster") | ||
|
||
if seeds: | ||
seeds = split_hosts(",".join(seeds)) | ||
if hosts: | ||
hosts = frozenset(split_hosts(",".join(hosts))) | ||
|
||
if seeds or num_seeds: | ||
result = parse_uri(uri, validate=True) | ||
if seeds is not None: | ||
self.assertEqual(sorted(result["nodelist"]), sorted(seeds)) | ||
if num_seeds is not None: | ||
self.assertEqual(len(result["nodelist"]), num_seeds) | ||
if options: | ||
opts = result["options"] | ||
if "readpreferencetags" in opts: | ||
rpts = validate_read_preference_tags( | ||
"readPreferenceTags", opts.pop("readpreferencetags") | ||
) | ||
opts["readPreferenceTags"] = rpts | ||
self.assertEqual(result["options"], options) | ||
if parsed_options: | ||
for opt, expected in parsed_options.items(): | ||
if opt == "user": | ||
self.assertEqual(result["username"], expected) | ||
elif opt == "password": | ||
self.assertEqual(result["password"], expected) | ||
elif opt == "auth_database" or opt == "db": | ||
self.assertEqual(result["database"], expected) | ||
|
||
hostname = next(iter(async_client_context.client.nodes))[0] | ||
# The replica set members must be configured as 'localhost'. | ||
if hostname == "localhost": | ||
copts = async_client_context.default_client_options.copy() | ||
# Remove tls since SRV parsing should add it automatically. | ||
copts.pop("tls", None) | ||
if async_client_context.tls: | ||
# Our test certs don't support the SRV hosts used in these | ||
# tests. | ||
copts["tlsAllowInvalidHostnames"] = True | ||
|
||
client = AsyncPyMongoTestCase.unmanaged_simple_client(uri, **copts) | ||
if client._options.connect: | ||
await client.aconnect() | ||
if num_seeds is not None: | ||
self.assertEqual(len(client._topology_settings.seeds), num_seeds) | ||
if hosts is not None: | ||
await async_wait_until( | ||
lambda: hosts == client.nodes, "match test hosts to client nodes" | ||
) | ||
if num_hosts is not None: | ||
await async_wait_until( | ||
lambda: num_hosts == len(client.nodes), "wait to connect to num_hosts" | ||
) | ||
if test_case.get("ping", True): | ||
await client.admin.command("ping") | ||
# XXX: we should block until SRV poller runs at least once | ||
# and re-run these assertions. | ||
await client.close() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This can be removed since our clients are closed automatically when using the helper methods. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yeah, make sense :) |
||
else: | ||
try: | ||
parse_uri(uri) | ||
except (ConfigurationError, ValueError): | ||
pass | ||
else: | ||
self.fail("failed to raise an exception") | ||
|
||
return run_test | ||
|
||
|
||
def create_tests(cls): | ||
for filename in glob.glob(os.path.join(cls.TEST_PATH, "*.json")): | ||
test_suffix, _ = os.path.splitext(os.path.basename(filename)) | ||
with open(filename) as dns_test_file: | ||
test_method = create_test(json.load(dns_test_file)) | ||
setattr(cls, "test_" + test_suffix, test_method) | ||
|
||
|
||
create_tests(TestDNSRepl) | ||
create_tests(TestDNSLoadBalanced) | ||
create_tests(TestDNSSharded) | ||
|
||
|
||
class TestParsingErrors(AsyncPyMongoTestCase): | ||
async def test_invalid_host(self): | ||
self.assertRaisesRegex( | ||
ConfigurationError, | ||
"Invalid URI host: mongodb is not", | ||
self.simple_client, | ||
"mongodb+srv://mongodb", | ||
) | ||
self.assertRaisesRegex( | ||
ConfigurationError, | ||
"Invalid URI host: mongodb.com is not", | ||
self.simple_client, | ||
"mongodb+srv://mongodb.com", | ||
) | ||
self.assertRaisesRegex( | ||
ConfigurationError, | ||
"Invalid URI host: an IP address is not", | ||
self.simple_client, | ||
"mongodb+srv://127.0.0.1", | ||
) | ||
self.assertRaisesRegex( | ||
ConfigurationError, | ||
"Invalid URI host: an IP address is not", | ||
self.simple_client, | ||
"mongodb+srv://[::1]", | ||
) | ||
|
||
|
||
class IsolatedAsyncioTestCaseInsensitive(AsyncIntegrationTest): | ||
async def test_connect_case_insensitive(self): | ||
client = self.simple_client("mongodb+srv://TEST1.TEST.BUILD.10GEN.cc/") | ||
self.assertGreater(len(client.topology_description.server_descriptions()), 1) | ||
|
||
|
||
if __name__ == "__main__": | ||
unittest.main() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how do we decide when to use helper methods vs the unmanaged clients?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally you should always use helper methods unless we need a client somewhere entirely out of a unittest class context. Those situations should be very rare in our test suites.