PYTHON-5079 Convert test.test_dns to async #2096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoahStapp
requested changes
Jan 30, 2025
test/asynchronous/test_dns.py
Outdated
| # tests. | ||
| copts["tlsAllowInvalidHostnames"] = True | ||
|
|
||
| client = AsyncPyMongoTestCase.unmanaged_simple_client(uri, **copts) |
There was a problem hiding this comment.
Suggested change
| client = AsyncPyMongoTestCase.unmanaged_simple_client(uri, **copts) | |
| client = self.simple_client(uri, **copts) |
There was a problem hiding this comment.
how do we decide when to use helper methods vs the unmanaged clients?
There was a problem hiding this comment.
Generally you should always use helper methods unless we need a client somewhere entirely out of a unittest class context. Those situations should be very rare in our test suites.
test/asynchronous/test_dns.py
Outdated
| await client.admin.command("ping") | ||
| # XXX: we should block until SRV poller runs at least once | ||
| # and re-run these assertions. | ||
| await client.close() |
There was a problem hiding this comment.
This can be removed since our clients are closed automatically when using the helper methods.
There was a problem hiding this comment.
yeah, make sense :)
NoahStapp
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.