PHPLIB-1297: pre-4.4 mongos writeConcernError does not determine retryability #1221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
force-pushed
the
phplib-1297
branch
3 times, most recently
from
d45acaf to
61d2eaa
Compare
|
Note: Psalm CI failures depend on #1218 |
GromNaN
reviewed
Jan 24, 2024
…yability Synced with mongodb/specifications@3e60a7c A DRIVER_VERSION env var was added to the tests.yml GitHub workflow to reduce duplication.
GromNaN
approved these changes
Jan 24, 2024
alcaeus
approved these changes
Jan 25, 2024
| DRIVER_VERSION: "stable" | ||
| # TODO: change to "stable" once 1.18.0 is released | ||
| # DRIVER_VERSION: "stable" | ||
| DRIVER_VERSION: "mongodb/mongo-php-driver@master" |
There was a problem hiding this comment.
Nice, I'm a little embarrassed I didn't think of this sooner. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPLIB-1297
Synced with mongodb/specifications@3e60a7c
Depends on mongodb/mongo-php-driver#1511