Split and modify CRUD examples #1
Conversation
|
|
||
| $mm = new \MongoDB\Manager("mongodb://server1,server2/?replicaSet=FOOBAR"); | ||
|
|
||
| $results = $mm->executeWrite("db.collection", $batch, $writeOptions); |
There was a problem hiding this comment.
Other than InsertBatch telling us that the operations are inserts (by its class name), I don't see why we shouldn't just pass in an array of operations. This would mean we'd have specific methods like executeInsert(), which I think is fine. In the C code, it means there's no need to check the class and then branch off internally to the appropriate write method in libmongoc. Also, being able to pass an array of operations (e.g. documents to insert or the update arguments) in one shot addresses @derickr's concern about having a simple interface.
There was a problem hiding this comment.
Having a classname makes it easier and cleaner to validate the actual operations.
Having to validate enormous array all the time is both complex and not something you want to have multiple branches of in one method.
Allow individual classes to provide their own validation and then simply be typehinted simplifies the entire chain of events and allows us to keep small pieces of selfcontained code.
Having an executeInsert(array($document1, $document2)); is begging for validation issues and "whops, I did executeInsert($document)"
Providing a \MongoDB\Manager\CRUD->insertOne($document); is a trivial wrapper though we could also provide as part of the extension as a simplified helper API....
| $query = new \MongoDB\Query($criteria, $selector); | ||
| $query | ||
| ->setOrderBy(array('name' => 1)) | ||
| ->setComment('More special stuff') |
There was a problem hiding this comment.
http://docs.mongodb.org/manual/reference/operator/query-modifier/#operators
What do we do with all the other operators?
$query->setOperator($name, $value) ? feels a tinybit weird...
|
looks good. |
No description provided.