PHPC-742: Regex constructor should default flags arg to empty string #388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| array("regex" => $regexp), | ||
| ); | ||
|
|
||
| foreach($tests as $n => $test) { |
There was a problem hiding this comment.
Do you have intention of adding additional test cases? If not, we can do away with this foreach.
There was a problem hiding this comment.
It's a copy of #001, which had the same thing. I didn't want to deviate (or change an existing test).
There was a problem hiding this comment.
If you're merging this as-is, don't object if I go back and refactor this at some point. It's dead code that doesn't add any value to the test.
|
LGTM with above comments. I'll understand if you don't want to combine the omitted flag variations in the original test cases; however, I would like more descriptive test titles if we're keeping them split. |
|
Will update the test descriptions and merge. |
derickr
force-pushed
the
PHPC-742-regex-default
branch
from
5e7a059 to
85e8328
Compare
derickr
force-pushed
the
PHPC-742-regex-default
branch
from
85e8328 to
213a8f0
Compare
derickr
added a commit
that referenced
this pull request
Sep 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.