DOCSP-43912: Improve change stream code examples #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-php-library ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
GromNaN
requested changes
Jun 10, 2025
GromNaN
reviewed
Jun 12, 2025
| ['name' => 'Blarney Castle'], | ||
| ['$set' => ['cuisine' => 'Irish']] | ||
| ); | ||
| // end-update-for-change-stream |
There was a problem hiding this comment.
Missing newline at EOF.
Suggested change
| // end-update-for-change-stream | |
| // end-update-for-change-stream | |
Comment on lines
+24
to
+31
| do { | ||
| $changeStream->next(); | ||
|
|
||
| if ($changeStream->valid()) { | ||
| $event = $changeStream->current(); | ||
| echo toJSON($event), PHP_EOL; | ||
| } | ||
| } while (! $changeStream->valid() || $changeStream->current()['operationType'] !== 'invalidate'); |
There was a problem hiding this comment.
On reflection, this notation is much more complex than the previous example.
In my original comment the idea was rather to use while(true) like this:
Suggested change
| do { | |
| $changeStream->next(); | |
| if ($changeStream->valid()) { | |
| $event = $changeStream->current(); | |
| echo toJSON($event), PHP_EOL; | |
| } | |
| } while (! $changeStream->valid() || $changeStream->current()['operationType'] !== 'invalidate'); | |
| while (true) { | |
| $changeStream->next(); | |
| if (! $changeStream->valid()) { | |
| continue; | |
| } | |
| $event = $changeStream->current(); | |
| echo toJSON($event), PHP_EOL; | |
| if ($changeStream->current()['operationType'] === 'invalidate') { | |
| break; | |
| } | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-43912
Staging Links
Self-Review Checklist