DOCSP-41973 Read Landing Page #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-php-library ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lindseymoore
requested review from
a team and
GromNaN
and removed request for
a team
GromNaN
reviewed
Sep 26, 2024
Comment on lines
+56
to
+66
| for ($changeStream->rewind(); true; $changeStream->next()) { | ||
| if ( ! $changeStream->valid()) { | ||
| continue; | ||
| } | ||
| $event = $changeStream->current(); | ||
| echo toJSON($event) . PHP_EOL; | ||
|
|
||
| if ($event['operationType'] === 'invalidate') { | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
do...while would be more appropriate.
Suggested change
| for ($changeStream->rewind(); true; $changeStream->next()) { | |
| if ( ! $changeStream->valid()) { | |
| continue; | |
| } | |
| $event = $changeStream->current(); | |
| echo toJSON($event) . PHP_EOL; | |
| if ($event['operationType'] === 'invalidate') { | |
| break; | |
| } | |
| } | |
| $changeStream->rewind(); | |
| do { | |
| $changeStream->next(); | |
| if ($changeStream->valid()) { | |
| $event = $changeStream->current(); | |
| echo toJSON($event) . PHP_EOL; | |
| } | |
| } while ($event['operationType'] !== 'invalidate'); |
Have you looked at our changestream example?
There was a problem hiding this comment.
Because of time and for consistency with examples on the already approved Monitor Data Changes page, I'll keep as is here. I can look into revising the examples as you've suggested here in a future piece of work. Thanks!
Ticket: https://jira.mongodb.org/browse/DOCSP-43912
lindseymoore
merged commit c14727a
into
mongodb:php-standardization
4 of 5 checks passed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-41973
Staging - https://deploy-preview-148--docs-php-library.netlify.app/read/
Self-Review Checklist