feat: initial feature-flagged, new autocompleter MONGOSH-2036 #2424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

lerouxb merged 24 commits into main from use-new-autocomplete

May 27, 2025

Contributor

lerouxb commented Apr 1, 2025 •

edited

Loading

I filed a few TODOs as follow-up tickets.

~/mongo/mongosh % USE_NEW_AUTOCOMPLETE=true npm run start -- 'your connection string here'


          Initial feature-flagged, draft new autocompleter.

6a931fa

lerouxb commented

View reviewed changes

packages/shell-api/src/collection.ts Outdated Show resolved Hide resolved

lerouxb added 5 commits

April 2, 2025 11:14


          use the specified connection and db name

88edcd3


          port some tests to autocomplete

70168e6


          this one just worked

fd845e6


          also just works

b1ccc97


          use the new mongodb-schema

7fecfac

lerouxb mentioned this pull request

[WIP DO NOT MERGE] Autocomplete2 demo #2445

Closed

lerouxb commented

View reviewed changes

packages/e2e-tests/test/e2e-snippet.spec.ts Outdated Show resolved Hide resolved

lerouxb commented

View reviewed changes

packages/browser-runtime-core/src/open-context-runtime.ts Outdated Show resolved Hide resolved

lerouxb commented

View reviewed changes

packages/cli-repl/src/mongosh-repl.spec.ts Outdated Show resolved Hide resolved

lerouxb commented

View reviewed changes

packages/cli-repl/src/mongosh-repl.ts Outdated Show resolved Hide resolved

lerouxb commented

View reviewed changes

packages/cli-repl/src/mongosh-repl.ts Outdated Show resolved Hide resolved

addaleax reviewed

View reviewed changes

packages/cli-repl/src/mongosh-repl.spec.ts Outdated Show resolved Hide resolved

packages/shell-api/src/shell-instance-state.ts Outdated Show resolved Hide resolved

packages/shell-api/src/shell-instance-state.ts Outdated Show resolved Hide resolved


          Merge branch 'main' into use-new-autocomplete

30ad07e

lerouxb mentioned this pull request

chore: some deps are not just dev deps mongodb-js/devtools-shared#540

Merged

lerouxb added 8 commits

May 23, 2025 16:47


          backport the circular ref fix

16242e0


          just use an incrementing unique connection id

4c2a001


          better event based waiting

7731cd8


          add ticket number

824ea47


          add ticket number

df1c303


          add ticket number

f354fe3


          Merge branch 'main' into use-new-autocomplete

1e92a11


          Merge branch 'use-new-autocomplete' of https://github.com/mongodb-js/…

06b5b66

…mongosh into use-new-autocomplete

lerouxb marked this pull request as ready for review

May 26, 2025 12:06

lerouxb changed the title ~~feat: initial feature-flagged, draft new autocompleter MONGOSH-2036~~ feat: initial feature-flagged, new autocompleter MONGOSH-2036

lerouxb commented

View reviewed changes

packages/cli-repl/src/mongosh-repl.ts Outdated Show resolved Hide resolved

lerouxb commented

View reviewed changes

packages/cli-repl/src/mongosh-repl.ts Outdated Show resolved Hide resolved

lerouxb added 2 commits

May 26, 2025 13:45


          put mongodb-schema as a dep in the right place

729b4c1


          put mongodb-schema as a dep in the right place

691fdfe

addaleax reviewed

View reviewed changes

packages/shell-api/src/collection.ts Outdated Show resolved Hide resolved

packages/cli-repl/src/mongosh-repl.ts Outdated Show resolved Hide resolved

lerouxb added 3 commits

May 26, 2025 14:00


          don't add getConnectionId to the public interface

b7bba92


          move it back

1edc212


          remove the TODO again, can just use the constant

8b859ce

addaleax approved these changes

View reviewed changes


          add some options to the sample aggregate

001c1d0

lerouxb force-pushed the use-new-autocomplete branch from b86ded0 to 001c1d0 Compare

May 26, 2025 14:51

lerouxb commented

View reviewed changes

packages/shell-api/src/collection.ts

@@ @@ -2389,7 +2389,7 @@ export class Collection< @@
                 ): Promise<RunCommandCursor> {
                   this._emitCollectionApiCall('checkMetadataConsistency', { options });
-                  return this._database._runCursorCommand({
+                  return await this._database._runCursorCommand({

Contributor Author

lerouxb May 26, 2025

drive-by to silence eslint

lerouxb added 3 commits

May 26, 2025 16:02


          'new', not true

7e39d40


          unnecessary TODO

b3dd61b


          add an integration test

cf99e0b

lerouxb merged commit 493993e into main

131 of 136 checks passed

lerouxb deleted the use-new-autocomplete branch

May 27, 2025 06:45

addaleax added a commit that referenced this pull request


          Revert "feat: initial feature-flagged, new autocompleter MONGOSH-2036 (…

7dd0c0b

…#2424)"

This reverts commit 493993e.
Startup performance appears to have regressed around ~15 percent.

addaleax added a commit that referenced this pull request


          Revert "feat: initial feature-flagged, new autocompleter MONGOSH-2036" (

0387cea

#2461)

Revert "feat: initial feature-flagged, new autocompleter MONGOSH-2036 (#2424)"

This reverts commit 493993e.
Startup performance appears to have regressed around ~15 percent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet