Skip to content

chore: some deps are not just dev deps #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025
Merged

Conversation

lerouxb
Copy link
Collaborator

@lerouxb lerouxb commented May 23, 2025

Missed these and now when starting the CLI in mongodb-js/mongosh#2424

Error: Cannot find module '@mongodb-js/ts-autocomplete'
Require stack:
- /Users/leroux.bodenstein/mongo/mongosh/node_modules/@mongodb-js/mongodb-ts-autocomplete/dist/autocompleter.js
- /Users/leroux.bodenstein/mongo/mongosh/node_modules/@mongodb-js/mongodb-ts-autocomplete/dist/index.js
- /Users/leroux.bodenstein/mongo/mongosh/packages/cli-repl/lib/mongosh-repl.js
- /Users/leroux.bodenstein/mongo/mongosh/packages/cli-repl/lib/cli-repl.js
- /Users/leroux.bodenstein/mongo/mongosh/packages/cli-repl/lib/run.js
- /Users/leroux.bodenstein/mongo/mongosh/packages/cli-repl/bin/mongosh.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1225:15)
    at Module._load (node:internal/modules/cjs/loader:1051:27)
    at Module.require (node:internal/modules/cjs/loader:1311:19)
    at require (node:internal/modules/helpers:179:18)
    at Object.<anonymous> (/Users/leroux.bodenstein/mongo/mongosh/node_modules/@mongodb-js/mongodb-ts-autocomplete/dist/autocompleter.js:7:43)
    at Module._compile (node:internal/modules/cjs/loader:1469:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1548:10)
    at Module.load (node:internal/modules/cjs/loader:1288:32)
    at Module._load (node:internal/modules/cjs/loader:1104:12)
    at Module.require (node:internal/modules/cjs/loader:1311:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/Users/leroux.bodenstein/mongo/mongosh/node_modules/@mongodb-js/mongodb-ts-autocomplete/dist/autocompleter.js',
    '/Users/leroux.bodenstein/mongo/mongosh/node_modules/@mongodb-js/mongodb-ts-autocomplete/dist/index.js',
    '/Users/leroux.bodenstein/mongo/mongosh/packages/cli-repl/lib/mongosh-repl.js',
    '/Users/leroux.bodenstein/mongo/mongosh/packages/cli-repl/lib/cli-repl.js',
    '/Users/leroux.bodenstein/mongo/mongosh/packages/cli-repl/lib/run.js',
    '/Users/leroux.bodenstein/mongo/mongosh/packages/cli-repl/bin/mongosh.js'
  ]
}

@lerouxb lerouxb merged commit 375c05b into main May 23, 2025
30 checks passed
@lerouxb lerouxb deleted the some-deps-are-not-dev branch May 23, 2025 14:29
@@ -46,13 +46,18 @@
"reformat": "npm run prettier -- --write .",
"extract-types": "ts-node scripts/extract-types.ts"
},
"dependencies": {
"@mongodb-js/ts-autocomplete": "^0.3.0",
"@mongosh/shell-api": "^3.11.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lerouxb This one should almost certainly be a peer dependency

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants