fix: changed custom dollar_rounded format key and numFmtId to 188 #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create manually_test.yml * feature: init V7.0.0 * add comment to interface and main func & update readme --------- Co-authored-by: m.r <mr@example.com>
## Description `dollar_2` and `dollar_rounded` defined 2 different `formatCode`, although they have the same `key` and `numFmtId` set to 183. This cause an issue when using both formats in a sheet, where only 1 is applied because the `183` id is used for reference in the spreadsheet context. The fix is to set `dollar_rounded` id to something else: 188 (last used key value was 187). Also, ordered the object by key value for better readability.
|
@mohammadrezaeicode can you please review? 🙏 |
xergiodf
commented
Mar 12, 2025
There was a problem hiding this comment.
I can rollback the ordering if needed
xergiodf
commented
Mar 12, 2025
Comment on lines
+144
to
+145
| key: 188, | ||
| value: '<numFmt numFmtId="188" formatCode=""$"#,##0" />', |
|
Hi, Thank you for participating again. I’ve merged the changes. Please note that we have a formatMap option available, which can override existing formats and add new formats to the current ones. |
Oh! thanks for the advice. I'm still getting familiar with the library features. I'll keep contributing as possible 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
dollar_2anddollar_roundeddefined 2 differentformatCode, although they have the samekeyandnumFmtIdset to 183.This causes an issue when using both formats in a sheet, where only 1 is applied because the
183id is used for reference in the spreadsheet context.The fix is to set
dollar_roundedid to something else: 188 (last used key value was 187).Also, ordered the object by key value for better readability.
Type of Change
Testing
Steps:
maindollar_rounded