Skip to content

V7.0.0 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 16, 2025
Merged

V7.0.0 #4

merged 3 commits into from
Feb 16, 2025

Conversation

mohammadrezaeicode
Copy link
Owner

Pull Request

Description

Please include a summary of the changes and the motivation behind them.

New Features

  • A drop-down option (multi-select option) provides the ability to create a cell that contains multiple selectable values.sheet->[n]->dropDowns
  • The replaceInExcel functionality in Excel allows you to replace data in an existing file using flags provided within the spreadsheet.

Bug Fixes

  • generateExcel supports empty objects and will generate an empty Excel file.

Note

The related interface has not changed, so the sheet needs to be provided in TypeScript.

Improvements

  • Begin adding JSDoc comments to the main functions and interfaces.

Type of Change

Please select the type(s) of changes made in your pull request:

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (changes to documentation)
  • Other (please describe):

Related Issue

If applicable, please reference the issue number this PR addresses:

  • Closes #[issue-number]

Testing

Please describe how you have tested your changes:

  • I have tested my changes locally.
  • I have written tests for my changes.

@mohammadrezaeicode mohammadrezaeicode self-assigned this Feb 16, 2025
@mohammadrezaeicode mohammadrezaeicode added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 16, 2025
@mohammadrezaeicode mohammadrezaeicode merged commit d9ffc29 into main Feb 16, 2025
6 checks passed
mohammadrezaeicode added a commit that referenced this pull request Feb 16, 2025
@mohammadrezaeicode
V7.0.0 (#4)
e81b1fd 
* Create manually_test.yml

* feature: init V7.0.0

* add comment to interface and main func & update readme

---------

Co-authored-by: m.r <mr@example.com>
mohammadrezaeicode added a commit that referenced this pull request Feb 16, 2025
@mohammadrezaeicode
V7.0.0 (#4)
797d1fb 
* Create manually_test.yml

* feature: init V7.0.0

* add comment to interface and main func & update readme

---------

Co-authored-by: m.r <mr@example.com>
mohammadrezaeicode added a commit that referenced this pull request Feb 16, 2025
@mohammadrezaeicode
V7.0.0 (#4)
7173313 
* Create manually_test.yml

* feature: init V7.0.0

* add comment to interface and main func & update readme

---------

Co-authored-by: m.r <mr@example.com>
mohammadrezaeicode added a commit that referenced this pull request Feb 16, 2025
@mohammadrezaeicode
V7.0.0 (#4)
c07ee4f 
* Create manually_test.yml

* feature: init V7.0.0

* add comment to interface and main func & update readme

---------

Co-authored-by: m.r <mr@example.com>
mohammadrezaeicode added a commit that referenced this pull request Feb 16, 2025
@mohammadrezaeicode
V7.0.0 (#4)
0ae6a12 
* Create manually_test.yml

* feature: init V7.0.0

* add comment to interface and main func & update readme

---------

Co-authored-by: m.r <mr@example.com>
mohammadrezaeicode added a commit that referenced this pull request Feb 16, 2025
@mohammadrezaeicode
V7.0.0 (#4)
4478c45 
* Create manually_test.yml

* feature: init V7.0.0

* add comment to interface and main func & update readme

---------

Co-authored-by: m.r <mr@example.com>
mohammadrezaeicode added a commit that referenced this pull request Feb 16, 2025
@mohammadrezaeicode
V7.0.0 (#4)
8452b41 
* Create manually_test.yml

* feature: init V7.0.0

* add comment to interface and main func & update readme

---------

Co-authored-by: m.r <mr@example.com>
mohammadrezaeicode added a commit that referenced this pull request Feb 16, 2025
@mohammadrezaeicode
V7.0.0 (#4)
0625980 
* Create manually_test.yml

* feature: init V7.0.0

* add comment to interface and main func & update readme

---------

Co-authored-by: m.r <mr@example.com>
mohammadrezaeicode added a commit that referenced this pull request Feb 16, 2025
@mohammadrezaeicode
V7.0.0 (#4)
33114db 
* Create manually_test.yml

* feature: init V7.0.0

* add comment to interface and main func & update readme

---------

Co-authored-by: m.r <mr@example.com>
mohammadrezaeicode added a commit that referenced this pull request Feb 16, 2025
@mohammadrezaeicode
V7.0.0 (#4)
ceb6826 
* Create manually_test.yml

* feature: init V7.0.0

* add comment to interface and main func & update readme

---------

Co-authored-by: m.r <mr@example.com>
mohammadrezaeicode added a commit that referenced this pull request Feb 16, 2025
@mohammadrezaeicode
V7.0.0 (#4)
1c4c972 
* Create manually_test.yml

* feature: init V7.0.0

* add comment to interface and main func & update readme

---------

Co-authored-by: m.r <mr@example.com>
mohammadrezaeicode added a commit that referenced this pull request Feb 16, 2025
@mohammadrezaeicode
V7.0.0 (#4)
3f11239 
* Create manually_test.yml

* feature: init V7.0.0

* add comment to interface and main func & update readme

---------

Co-authored-by: m.r <mr@example.com>
mohammadrezaeicode added a commit that referenced this pull request Feb 16, 2025
@mohammadrezaeicode
V7.0.0 (#4)
9b8e71d 
* Create manually_test.yml

* feature: init V7.0.0

* add comment to interface and main func & update readme

---------

Co-authored-by: m.r <mr@example.com>
mohammadrezaeicode added a commit that referenced this pull request Feb 16, 2025
@mohammadrezaeicode
V7.0.0 (#4)
26f9df5 
* Create manually_test.yml

* feature: init V7.0.0

* add comment to interface and main func & update readme

---------

Co-authored-by: m.r <mr@example.com>
mohammadrezaeicode added a commit that referenced this pull request Feb 16, 2025
@mohammadrezaeicode
V7.0.0 (#4)
1692a52 
* Create manually_test.yml

* feature: init V7.0.0

* add comment to interface and main func & update readme

---------

Co-authored-by: m.r <mr@example.com>
mohammadrezaeicode added a commit that referenced this pull request Feb 16, 2025
@mohammadrezaeicode
V7.0.0 (#4)
c69079a 
* Create manually_test.yml

* feature: init V7.0.0

* add comment to interface and main func & update readme

---------

Co-authored-by: m.r <mr@example.com>
mohammadrezaeicode added a commit that referenced this pull request Feb 16, 2025
@mohammadrezaeicode
V7.0.0 (#4)
a5e5e2b 
* Create manually_test.yml

* feature: init V7.0.0

* add comment to interface and main func & update readme

---------

Co-authored-by: m.r <mr@example.com>
mohammadrezaeicode added a commit that referenced this pull request Feb 16, 2025
@mohammadrezaeicode
V7.0.0 (#4)
c371a16 
* Create manually_test.yml

* feature: init V7.0.0

* add comment to interface and main func & update readme

---------

Co-authored-by: m.r <mr@example.com>
mohammadrezaeicode added a commit that referenced this pull request Feb 16, 2025
@mohammadrezaeicode
V7.0.0 (#4)
540a99a 
* Create manually_test.yml

* feature: init V7.0.0

* add comment to interface and main func & update readme

---------

Co-authored-by: m.r <mr@example.com>
mohammadrezaeicode added a commit that referenced this pull request Feb 16, 2025
@mohammadrezaeicode
V7.0.0 (#4)
3b5cdb0 
* Create manually_test.yml

* feature: init V7.0.0

* add comment to interface and main func & update readme

---------

Co-authored-by: m.r <mr@example.com>
mohammadrezaeicode added a commit that referenced this pull request Feb 16, 2025
@mohammadrezaeicode
V7.0.0 (#4)
992a16e 
* Create manually_test.yml

* feature: init V7.0.0

* add comment to interface and main func & update readme

---------

Co-authored-by: m.r <mr@example.com>
mohammadrezaeicode added a commit that referenced this pull request Feb 16, 2025
@mohammadrezaeicode
V7.0.0 (#4)
0a45006 
* Create manually_test.yml

* feature: init V7.0.0

* add comment to interface and main func & update readme

---------

Co-authored-by: m.r <mr@example.com>
mohammadrezaeicode added a commit that referenced this pull request Feb 16, 2025
@mohammadrezaeicode
V7.0.0 (#4)
ec1fb1d 
* Create manually_test.yml

* feature: init V7.0.0

* add comment to interface and main func & update readme

---------

Co-authored-by: m.r <mr@example.com>
mohammadrezaeicode added a commit that referenced this pull request Feb 16, 2025
@mohammadrezaeicode
V7.0.0 (#4)
d322cb4 
* Create manually_test.yml

* feature: init V7.0.0

* add comment to interface and main func & update readme

---------

Co-authored-by: m.r <mr@example.com>
mohammadrezaeicode added a commit that referenced this pull request Feb 16, 2025
@mohammadrezaeicode
V7.0.0 (#4)
4014f14 
* Create manually_test.yml

* feature: init V7.0.0

* add comment to interface and main func & update readme

---------

Co-authored-by: m.r <mr@example.com>
mohammadrezaeicode added a commit that referenced this pull request Feb 16, 2025
@mohammadrezaeicode
V7.0.0 (#4)
3cb1422 
* Create manually_test.yml

* feature: init V7.0.0

* add comment to interface and main func & update readme

---------

Co-authored-by: m.r <mr@example.com>
mohammadrezaeicode added a commit that referenced this pull request Feb 16, 2025
@mohammadrezaeicode
V7.0.0 (#4)
ce6aa18 
* Create manually_test.yml

* feature: init V7.0.0

* add comment to interface and main func & update readme

---------

Co-authored-by: m.r <mr@example.com>
mohammadrezaeicode added a commit that referenced this pull request Feb 16, 2025
@mohammadrezaeicode
V7.0.0 (#4)
7e5da30 
* Create manually_test.yml

* feature: init V7.0.0

* add comment to interface and main func & update readme

---------

Co-authored-by: m.r <mr@example.com>
mohammadrezaeicode added a commit that referenced this pull request Mar 12, 2025
@xergiodf @mohammadrezaeicode
fix: changed custom dollar_rounded format key and numFmtId to 188 (#5)
ac9d7f5 
* V7.0.0 (#4)

* Create manually_test.yml

* feature: init V7.0.0

* add comment to interface and main func & update readme

---------

Co-authored-by: m.r <mr@example.com>

* fix: changed custom dollar_rounded format key and numFmtId to 188

## Description

`dollar_2` and `dollar_rounded` defined 2 different `formatCode`, although they have the same `key` and `numFmtId` set to 183.

This cause an issue when using both formats in a sheet, where only 1 is applied because the `183` id is used for reference in the spreadsheet context.

The fix is to set `dollar_rounded` id to something else: 188 (last used key value was 187).

Also, ordered the object by key value for better readability.

---------

Co-authored-by: mohammadrezaeicode <131792366+mohammadrezaeicode@users.noreply.github.com>
Co-authored-by: m.r <mr@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mohammadrezaeicode mohammadrezaeicode

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mohammadrezaeicode