Skip to content

Move the logic into a trait, so it is accessible without extending the provided base model (eg for projects which already have a base model) #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 17, 2018

Conversation

robert-moore96
Copy link
Contributor

mostly just moving the code into the cachable trait, altohugh also cleaned up the boot method a little

the model instance gets passed to the event listeners by laravel anyway, and saved gets called for all the events so no need to handle created/updated/deleted as well

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling bc68fda on RMoorePHP:master into b49e122 on GeneaLabs:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling bc68fda on RMoorePHP:master into b49e122 on GeneaLabs:master.

@mikebronner
Copy link
Owner

Thanks @rs-sliske ! I've been thinking about this as well, you beat me to it! :) I'm traveling until Tuesday, but will take a look at it as soon as I get back to the office.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants