vsprintf(): Too few arguments

[rajnishmishra20]

Describe the bug
Exception occurs when using eagerLoadRelation on Model with Cachable trait.

Eloquent Query

$parents = Category::where('category_id', Category::encodeUuid($uuid))->with('word')->with('posts')->withCount('posts')->get();

Stack Trace
vsprintf(): Too few arguments

protected function getInAndNotInClauses(array $where) : string
{
    if (! in_array($where["type"], ["In", "NotIn", "InRaw"])) {
        return "";
    }

    $type = strtolower($where["type"]);
    $subquery = $this->getValuesFromWhere($where);
    $values = collect($this->query->bindings["where"][$this->currentBinding] ?? []);
    $this->currentBinding += count($where["values"]);
    $subquery = collect(**vsprintf**(str_replace("?", "%s", $subquery), $values->toArray()));
    $values = $this->recursiveImplode($subquery->toArray(), "_");

    return "-{$where["column"]}_{$type}{$values}";
}

Environment

• PHP: [ 7.3.0]
• OS: [ Ubuntu 18.04]
• Laravel: [e.g. 5.8.]
• Model Caching: [ 0.7] (*)

Model uses \Ramsey\Uuid\Uuid for primary keys

[mikebronner]

@rajnishmishra20 Thanks for reporting this. Could you provide the complete stack trace entry from /storage/logs/laravel.log? Thanks!

[mikebronner]

@rajnishmishra20 Thanks, that helps. I will try to get a fix out today or tomorrow.

[mikebronner]

@rajnishmishra20 Are you able to reproduce this in a model that doesn't use UUID?
Also, can you provide me the string value of Category::encodeUuid($uuid)? Thanks. I am currently unable to replicate the issue using the following query:

        $parents = (new Book)
            ->where('author_id', 1)
            ->with('stores')
            ->with('publisher')
            ->withCount('stores')
            ->get();

[rajnishmishra20]

Hi I am \Ramsey\Uuid\Uuid for primary keys

This is Category::decodeUuid($uuid) 8eae24c5cd3a484fb95259066fa9e83f

This is Category::encodeUuid($uuid) b"Ž®$ÅÍ:HO¹RY\x06o©è?"

Hope this helps.

[mikebronner]

@rajnishmishra20 Thanks, this helps. The problem is the question mark in the ID. I will see what I can do to work around this. Hopefully I will have an update ready sometime in the next few days.

[mikebronner]

@rajnishmishra20 This should now be fixed in release 0.7.3. Could you let me know how that works for you? Thanks!

[rajnishmishra20]

Its fine now. Thanks!

[rajnishmishra20]

Hey Sorry to open this again but it did not work. I had MODEL_CACHE_ENABLED set to false

After enabling , same error occurs

My Query

Category::with('word')->with('contents')->with('category')->doesntHave('category')->with('packswithcontents')->simplePaginate($pages)

for a temporary access here is the url https://dev.coloursapp.com/api/content/v1/categories

    protected function getInAndNotInClauses(array $where) : string
    {
        if (! in_array($where["type"], ["In", "NotIn", "InRaw"])) {
            return "";
        }
 
        $type = strtolower($where["type"]);
        $subquery = $this->getValuesFromWhere($where);
        $values = collect($this->query->bindings["where"][$this->currentBinding] ?? []);
        $this->currentBinding += count($where["values"]);
        $subquery = preg_replace('/\?(?=(?:[^"]*"[^"]*")*[^"]*\Z)/m', "_??_", $subquery);
###       $subquery = collect(vsprintf(str_replace("_??_", "%s", $subquery), $values->toArray()));
        $values = $this->recursiveImplode($subquery->toArray(), "_");
 
        return "-{$where["column"]}_{$type}{$values}";
    }

[mikebronner]

Hi @rajnishmishra20, could you provide the stacktrace again, as well as the category UUIDs that cause this error? Thanks!