This repository was archived by the owner on Oct 1, 2024. It is now read-only.
Fix incorrect loaded boards when platform name changes #1513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gandarez
changed the title
gandarez
changed the title
|
anyone? |
|
@gandarez I pulled in your code and fixed a slight error. I played with it some and didn't notice any glaring errors pop up and am planning to complete the PR shortly! (Assuming no issues in the builds arrive) |
gcampbell-msft
approved these changes
Jun 21, 2022
|
/azp run |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
Board Managershowing less vesions than expected. It happens because platform name may change between releases and there's a condtion which skips any other than the first one added. To keep the same behaviour as Arduino IDE it will always keep the latest platform name as source of truth.Fixes #1511