-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Wishlist validation added for grouped product #39497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.4-develop
Are you sure you want to change the base?
Wishlist validation added for grouped product #39497
Conversation
Hi @Mohamed-Asar. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
@magento run all tests |
@magento run Unit Tests, Static Tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Mohamed-Asar,
Thanks for the contribution!
The code changes seems good the us, but please fix the failed static tests and validate that the new logic correctly identifies valid and invalid quantities.
Suggesting test cases as below:
- Single input.qty element with valid data.
- Single input.qty element with invalid data.
- Multiple input.qty elements with a mix of valid and invalid data.
And also if you feel that this PR is depends on this #39480, can we merge the changes of this PR with #39480?
Hello @Mohamed-Asar, Have you got a chance to look into the review comments? Thanks |
@engcom-Hotel Better we can merge this pr after this PR Let me check and fix the failed tests |
Hello @Mohamed-Asar, Gentle reminder for this PR! Thanks |
@engcom-Hotel i have started working on it. will let you know once done |
@magento run all tests |
@engcom-Hotel Fixed the static tests failures, please review |
Description (*)
Validation added for grouped while add child products to wishlist
Fixed Issues (if relevant)
Additional Info
This PR depends on this PR
Manual testing scenarios (*)
1.Open grouped product PDP, Fill invalid inputs
3. Click add to wishlist
Contribution checklist (*)