Skip to content

Wishlist validation added for grouped product #39497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

Mohamed-Asar
Copy link
Contributor

@Mohamed-Asar Mohamed-Asar commented Dec 20, 2024

Description (*)

Validation added for grouped while add child products to wishlist

Fixed Issues (if relevant)

  1. Fixes Grouped Product Wishlist Validations are not working #39496

Additional Info

This PR depends on this PR

Manual testing scenarios (*)

1.Open grouped product PDP, Fill invalid inputs
3. Click add to wishlist

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Copy link

m2-assistant bot commented Dec 20, 2024

Hi @Mohamed-Asar. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-github-services m2-github-services added Partner: Ziffity partners-contribution Pull Request is created by Magento Partner labels Dec 20, 2024
@m2-community-project m2-community-project bot added Progress: pending review Priority: P2 A defect with this priority could have functionality issues which are not to expectations. labels Dec 20, 2024
@engcom-Charlie engcom-Charlie added the Project: Community Picked PRs upvoted by the community label Apr 10, 2025
@engcom-Charlie engcom-Charlie moved this to Pending Review in Community Dashboard Apr 10, 2025
@Mohamed-Asar Mohamed-Asar changed the title Wishlist validation added for gropued product Wishlist validation added for grouped product Apr 18, 2025
@engcom-Hotel
Copy link
Contributor

@magento run all tests

@engcom-Hotel
Copy link
Contributor

@magento run Unit Tests, Static Tests

Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Mohamed-Asar,

Thanks for the contribution!

The code changes seems good the us, but please fix the failed static tests and validate that the new logic correctly identifies valid and invalid quantities.

Suggesting test cases as below:

  • Single input.qty element with valid data.
  • Single input.qty element with invalid data.
  • Multiple input.qty elements with a mix of valid and invalid data.

And also if you feel that this PR is depends on this #39480, can we merge the changes of this PR with #39480?

@engcom-Hotel engcom-Hotel moved this from Pending Review to Changes Requested in Community Dashboard Apr 28, 2025
@engcom-Hotel
Copy link
Contributor

Hello @Mohamed-Asar,

Have you got a chance to look into the review comments?

Thanks

@Mohamed-Asar
Copy link
Contributor Author

@engcom-Hotel Better we can merge this pr after this PR

Let me check and fix the failed tests

@engcom-Hotel
Copy link
Contributor

Hello @Mohamed-Asar,

Gentle reminder for this PR!

Thanks

@Mohamed-Asar
Copy link
Contributor Author

@engcom-Hotel i have started working on it. will let you know once done

@Mohamed-Asar
Copy link
Contributor Author

@magento run all tests

@Mohamed-Asar
Copy link
Contributor Author

@engcom-Hotel Fixed the static tests failures, please review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: Ziffity partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: review Project: Community Picked PRs upvoted by the community
Projects
Status: Review in Progress
Development

Successfully merging this pull request may close these issues.

Grouped Product Wishlist Validations are not working
5 participants