Grouped product frontend quantity validation added and code refactor #39480

Mohamed-Asar · 2024-12-15T05:26:37Z

Description (*)

Grouped Product Frontend Quantity validation added

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

1.Create a Grouped Product and associate it with child products.
2. Set the following quantity properties for one of the child products:
- Minimum Qty Allowed in Shopping Cart: 2
- Maximum Qty Allowed in Shopping Cart: 10
- Qty Increments: 2
3.Open the Product Detail Page (PDP) of the Grouped Product and test invalid quantities for the selected child product (e.g., 1, 3, or 11) to confirm that invalid inputs are restricted.

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

m2-assistant · 2024-12-15T05:26:41Z

Hi @Mohamed-Asar. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

Mohamed-Asar · 2024-12-18T07:08:50Z

@magento run all tests.

magento-automated-testing · 2024-12-18T07:08:58Z

Failed to run the builds. Please try to re-run them later.

Mohamed-Asar · 2024-12-18T07:09:52Z

@magento run all tests

…into bug/39479-grouped-product-qty-validation

…thub.com/Mohamed-Asar/magento2 into bug/39479-grouped-product-qty-validation

Mohamed-Asar · 2024-12-28T12:59:33Z

@magento run all tests

…into bug/39479-grouped-product-qty-validation

Mohamed-Asar · 2024-12-30T05:59:55Z

@magento run all tests

Mohamed-Asar · 2024-12-30T13:04:15Z

@magento run all tests

Mohamed-Asar · 2024-12-31T09:33:34Z

@magento run all tests

Copilot

Pull Request Overview

This pull request introduces frontend quantity validation for grouped products and refactors the related code. Key changes include:

Adding a bypass for validation when the quantity is zero in the validation JavaScript.
Introducing a new ValidateQuantity ViewModel and updating layout XML files and product view templates accordingly.
Refactoring the CatalogInventory quantity validator and updating associated tests and plugins.

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
lib/web/mage/validation.js	Added early return logic for zero quantity based on a data attribute.
app/code/Magento/Wishlist/view/frontend/layout/wishlist_index_configure_type_grouped.xml	Updated layout to inject the ValidateQuantity ViewModel.
app/code/Magento/GroupedProduct/view/frontend/templates/product/view/type/grouped.phtml	Updated template to use the new ViewModel and a dedicated escaper for output.
app/code/Magento/GroupedProduct/view/frontend/layout/catalog_product_view_type_grouped.xml	Similar layout XML updates for grouped products.
app/code/Magento/GroupedProduct/ViewModel/ValidateQuantity.php	Introduced new ViewModel to encapsulate quantity validation data.
app/code/Magento/CatalogInventory/Model/Product/QuantityValidator.php	Refactored logic to retrieve quantity validation parameters.
app/code/Magento/CatalogInventory/Block/Plugin/ProductView.php	Updated plugin to use the new QuantityValidator.
app/code/Magento/CatalogInventory/Test/Unit/Model/Product/QuantityValidatorTest.php	Updated unit tests for the quantity validation logic.
app/code/Magento/CatalogInventory/Test/Unit/Block/Plugin/ProductViewTest.php	Removed outdated test file; ensure test coverage is maintained elsewhere.
app/code/Magento/Catalog/Test/Mftf/Test/AdminAddInStockProductToTheCartTest.xml	Adjusted test quantities to align with the new validation requirements.

Comments suppressed due to low confidence (2)

app/code/Magento/CatalogInventory/Test/Unit/Block/Plugin/ProductViewTest.php:1

[nitpick] Ensure that the removal of the ProductViewTest file does not create any gaps in test coverage for the ProductView functionality.

Entire file removed

app/code/Magento/GroupedProduct/view/frontend/templates/product/view/type/grouped.phtml:11

The variable '$escaper' is annotated but not initialized. Consider initializing it (e.g., via $block->getEscaper()) to avoid potential undefined variable errors.

* @var $escaper \Magento\Framework\Escaper

Copilot · 2025-05-27T10:32:33Z

lib/web/mage/validation.js

@@ -1643,6 +1643,9 @@ define([
                    isQtyIncrementsValid = typeof params.qtyIncrements === 'undefined' ||
                        resolveModulo(qty, $.mage.parseNumber(params.qtyIncrements)) === 0.0;

+                if ($(element).data('no-validation-for-zero-qty') === true && qty === 0) {


[nitpick] Consider adding an inline comment to explain the purpose of the 'no-validation-for-zero-qty' data attribute for future maintainability and clarity.

Copilot · 2025-05-27T10:32:34Z

app/code/Magento/CatalogInventory/Model/Product/QuantityValidator.php

+        if ($stockItem->getMaxSaleQty()) {
+            $params['maxAllowed'] = $stockItem->getMaxSaleQty();
+        }
+        if ($stockItem->getQtyIncrements() > 0) {


[nitpick] Consider explicitly verifying that the return value of getQtyIncrements() is numeric before performing the comparison to ensure type safety.

Suggested change

if ($stockItem->getQtyIncrements() > 0) {

if (is_numeric($stockItem->getQtyIncrements()) && $stockItem->getQtyIncrements() > 0) {

engcom-Bravo · 2025-05-28T06:05:02Z

Hi @Mohamed-Asar,

Thanks for your Contribution!!.

Could you please resolve the Conflicts to proceed further.

Thanks.

Mohamed-Asar · 2025-05-28T08:05:45Z

@engcom-Bravo I fixed the conflicts, please check

engcom-Hotel · 2025-05-29T04:16:59Z

@magento run all tests

engcom-Bravo · 2025-05-30T08:34:23Z

Hi @Mohamed-Asar,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

Install fresh Magento 2.4-develop

Steps to reproduce

Create a Grouped Product and associate it with child products.
Set the following quantity properties for one of the child products:
- Minimum Qty Allowed in Shopping Cart: 2
- Maximum Qty Allowed in Shopping Cart: 10
- Qty Increments: 2
.Open the Product Detail Page (PDP) of the Grouped Product and test invalid quantities for the selected child product (e.g., 1, 3, or 11) to confirm that invalid inputs are restricted.

Before: ✖️

After: ✔️

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

engcom-Dash · 2025-05-30T10:27:59Z

@magento run all tests

engcom-Dash · 2025-06-02T06:28:52Z

@magento run all tests

engcom-Dash · 2025-06-02T09:29:13Z

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Static Tests, Unit Tests

Grouped product frontend quantity validation added and code refactor

f990b58

m2-github-services added Partner: Ziffity partners-contribution Pull Request is created by Magento Partner labels Dec 15, 2024

m2-community-project bot added Progress: pending review Priority: P2 A defect with this priority could have functionality issues which are not to expectations. labels Dec 15, 2024

Merge branch '2.4-develop' into bug/39479-grouped-product-qty-validation

5f2b740

Mohamed-Asar added 3 commits December 20, 2024 10:39

Merge branch '2.4-develop' of https://github.com/Mohamed-Asar/magento2 …

52bd8e8

…into bug/39479-grouped-product-qty-validation

Ignore item qty validation if zero qty entered in grouped product

94fadc8

Merge branch 'bug/39479-grouped-product-qty-validation' of https://gi…

9ac7ef5

…thub.com/Mohamed-Asar/magento2 into bug/39479-grouped-product-qty-validation

Mohamed-Asar added 2 commits December 30, 2024 11:18

Merge branch '2.4-develop' of https://github.com/Mohamed-Asar/magento2 …

eea8ae5

…into bug/39479-grouped-product-qty-validation

Unit test & static test cases issues fixed

a192377

Static test fixed

ceb8597

Indent issue fixed

3e0c5a7

Priyakshic added the Project: Community Picked PRs upvoted by the community label Jan 15, 2025

magento-ct-gh-projects-svc added Progress: review and removed Progress: pending review Progress: review labels Jan 22, 2025

Copilot AI reviewed May 27, 2025

View reviewed changes

engcom-Hotel approved these changes May 27, 2025

View reviewed changes

ct-prd-projects-boards-automation bot removed the Progress: review label May 27, 2025

ct-prd-projects-boards-automation bot moved this from Review in Progress to Ready for Testing in Community Dashboard May 27, 2025

ct-prd-projects-boards-automation bot added the Progress: ready for testing label May 27, 2025

engcom-Bravo moved this from Ready for Testing to Changes Requested in Community Dashboard May 28, 2025

ct-prd-projects-boards-automation bot added the Progress: needs update label May 28, 2025

Conflicts fixed

5330948

engcom-Bravo requested a review from engcom-Hotel May 28, 2025 08:13

ct-prd-projects-boards-automation bot added Progress: review and removed Progress: needs update labels May 28, 2025

ct-prd-projects-boards-automation bot moved this from Pending Review to Review in Progress in Community Dashboard May 28, 2025

engcom-Bravo moved this from Changes Requested to Pending Review in Community Dashboard May 28, 2025

ct-prd-projects-boards-automation bot added Progress: pending review and removed Progress: pending review labels May 28, 2025

engcom-Hotel approved these changes May 29, 2025

View reviewed changes

ct-prd-projects-boards-automation bot removed the Progress: review label May 29, 2025

ct-prd-projects-boards-automation bot moved this from Review in Progress to Ready for Testing in Community Dashboard May 29, 2025

engcom-Bravo self-assigned this May 30, 2025

engcom-Bravo moved this from Ready for Testing to Testing in Progress in Community Dashboard May 30, 2025

engcom-Bravo moved this from Testing in Progress to Extended testing (optional) in Community Dashboard May 30, 2025

engcom-Dash self-assigned this May 30, 2025

Merge branch '2.4-develop' into bug/39479-grouped-product-qty-validation

2fe7d64

	if ($stockItem->getQtyIncrements() > 0) {
	if (is_numeric($stockItem->getQtyIncrements()) && $stockItem->getQtyIncrements() > 0) {

Grouped product frontend quantity validation added and code refactor #39480

Are you sure you want to change the base?

Grouped product frontend quantity validation added and code refactor #39480

Conversation

Mohamed-Asar commented Dec 15, 2024

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Dec 15, 2024

Uh oh!

Mohamed-Asar commented Dec 18, 2024

Uh oh!

magento-automated-testing bot commented Dec 18, 2024

Uh oh!

Mohamed-Asar commented Dec 18, 2024

Uh oh!

Mohamed-Asar commented Dec 28, 2024

Uh oh!

Mohamed-Asar commented Dec 30, 2024

Uh oh!

Mohamed-Asar commented Dec 30, 2024

Uh oh!

Mohamed-Asar commented Dec 31, 2024

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI May 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 27, 2025

Choose a reason for hiding this comment

Uh oh!

engcom-Bravo commented May 28, 2025

Uh oh!

Mohamed-Asar commented May 28, 2025

Uh oh!

engcom-Hotel commented May 29, 2025

Uh oh!

engcom-Bravo commented May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✔️ QA Passed

Uh oh!

engcom-Dash commented May 30, 2025

Uh oh!

engcom-Dash commented Jun 2, 2025

Uh oh!

engcom-Dash commented Jun 2, 2025

Uh oh!

Uh oh!

engcom-Bravo commented May 30, 2025 •

edited

Loading