Skip to content

Fixed issue #20030 :Customer EAV Decimal Attribute required allow 0 #20130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 19, 2019

Conversation

shikhamis11
Copy link
Member

Fixed issue #20030
Customer EAV Decimal Attribute required allow 0

Preconditions (*)

Magento Version 2.2.6

Steps to reproduce (*)

Create a new required customer attribute of type decimal with a default of 0 e.g.

'bal' => [
'is_used_in_grid' => false,
'is_visible_in_grid' => false,
'is_filterable_in_grid' => false,
'is_searchable_in_grid' => false,
'type' => 'decimal',
'label' => 'AR Balance',
'input' => 'text',
'required' => true,
'default' => 0,
'sort_order' => 202,
'visible' => true,
'system' => false,
'validate_rules' => null,
'position' => 202,
'user_defined' => false,
'frontend_class' => 'validate-number'
],

Attempt to create a customer on front-end, or attempt to assign the value of 0 through the API.

Expected result (*)

Customer attribute should be set with a 0 value.

Actual result (*)

Both of these fail with [Attribute] is a required value.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@davidverholen
Copy link
Member

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @davidverholen. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @davidverholen, here is your new Magento instance.
Admin access: https://pr-20130.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@davidverholen
Copy link
Member

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @davidverholen. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @davidverholen, here is your Magento instance.
Admin access: https://i-20130-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@magento-engcom-team
Copy link
Contributor

Hi @davidverholen, thank you for the review.
ENGCOM-3814 has been created to process this Pull Request

@davidverholen
Copy link
Member

module for testing the change: pr20130.tar.gz

@ghost
Copy link

ghost commented Jan 19, 2019

Hi @shikhamis11, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants