ENGCOM-3814: Static test fix.

Author: p-bystritsky

app/code/Magento/Eav/Model/Attribute/Data/AbstractData.php

@@ -143,6 +143,7 @@ public function setRequestScope($scope)
 
     /**
      * Set scope visibility
+     *
      * Search value only in scope or search value in scope and global
      *
      * @param bool $flag
@@ -296,7 +297,7 @@ protected function _applyOutputFilter($value)
      * Validate value by attribute input validation rule
      *
      * @param string $value
-     * @return string|true
+     * @return array|true
      * @SuppressWarnings(PHPMD.CyclomaticComplexity)
      * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
      */

app/code/Magento/Eav/Model/Attribute/Data/Text.php

@@ -72,20 +72,17 @@ public function validateValue($value)
             return true;
         }
 
-        if (empty($value) && $value !== '0' && $attribute->getDefaultValue() == NULL) {
+        if (empty($value) && $value !== '0' && $attribute->getDefaultValue() === null) {
             $label = __($attribute->getStoreLabel());
             $errors[] = __('"%1" is a required value.', $label);
         }
 
-        $result = $this->validateLength($attribute, $value);
-        if (count($result) !== 0) {
-            $errors = array_merge($errors, $result);
-        }
+        $validateLengthResult = $this->validateLength($attribute, $value);
+        $errors = array_merge($errors, $validateLengthResult);
+
+        $validateInputRuleResult = $this->validateInputRule($value);
+        $errors = array_merge($errors, $validateInputRuleResult);
 
-        $result = $this->_validateInputRule($value);
-        if ($result !== true) {
-            $errors = array_merge($errors, $result);
-        }
         if (count($errors) == 0) {
             return true;
         }
@@ -141,7 +138,7 @@ public function outputValue($format = \Magento\Eav\Model\AttributeDataFactory::O
      * @param string $value
      * @return array errors
      */
-    private function validateLength(\Magento\Eav\Model\Attribute $attribute, $value): array
+    private function validateLength(\Magento\Eav\Model\Attribute $attribute, string $value): array
     {
         $errors = [];
         $length = $this->_string->strlen(trim($value));
@@ -162,4 +159,16 @@ private function validateLength(\Magento\Eav\Model\Attribute $attribute, $value)
 
         return $errors;
     }
+
+    /**
+     * Validate value by attribute input validation rule.
+     *
+     * @param string $value
+     * @return array
+     */
+    private function validateInputRule(string $value): array
+    {
+        $result = $this->_validateInputRule($value);
+        return \is_array($result) ? $result : [];
+    }
 }