Refactor Code for Mass Order Unhold #14629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have observed that MassAction Unhold is using the collection to release order from hold, whereas MassAction Hold is using Interface to put the order on hold. So, I have refactor code in app/code/Magento/Sales/Controller/Adminhtml/Order/MassUnhold.php same as in app/code/Magento/Sales/Controller/Adminhtml/Order/MassHold.php
|
|
sidolov
requested changes
Apr 11, 2018
There was a problem hiding this comment.
@AnshuMishra17 , please, fix all issue according to review and take a look to failed tests
| /** | ||
| * @var OrderManagementInterface | ||
| */ | ||
| protected $orderManagement; |
There was a problem hiding this comment.
Please, make this property private
| */ | ||
| public function __construct(Context $context, Filter $filter, CollectionFactory $collectionFactory) | ||
| public function __construct(Context $context, Filter $filter, CollectionFactory $collectionFactory, OrderManagementInterface $orderManagement) |
There was a problem hiding this comment.
Please, add new dependencies according to our Backward Compatible Development Guide
There was a problem hiding this comment.
I have added backward compatibility.
Added backward compatibility for the new orderManagementInterface dependency and made the variable $orderManagement private.
|
Hi @AnshuMishra17 , I fixed test failures |
sidolov
approved these changes
Apr 12, 2018
magento-engcom-team
added
Release Line: 2.2
Progress: accept
and removed
Progress: needs update
labels
magento-engcom-team
pushed a commit
that referenced
this pull request
Apr 14, 2018
|
Hi @AnshuMishra17. Thank you for your contribution. |
sidolov
pushed a commit
to sidolov/magento2
that referenced
this pull request
Apr 19, 2018
sidolov
pushed a commit
to sidolov/magento2
that referenced
this pull request
Apr 19, 2018
rostyslav-hymon
pushed a commit
to rostyslav-hymon/magento2
that referenced
this pull request
Apr 20, 2018
This was referenced Apr 20, 2018
gelanivishal
pushed a commit
to gelanivishal/magento2
that referenced
this pull request
Jul 12, 2018
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have observed that MassAction Unhold is using the collection to release order from hold, whereas MassAction Hold is using Interface to put the order on hold.
So, I have refactor code in app/code/Magento/Sales/Controller/Adminhtml/Order/MassUnhold.php same as in app/code/Magento/Sales/Controller/Adminhtml/Order/MassHold.php
Manual testing scenarios