Skip to content

Refactor Mass Order UnHold code to use Interface #14631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

AnshuMishra17
Copy link
Contributor

Description

I have observed that MassAction Unhold is using the collection to release order from hold, whereas MassAction Hold is using Interface to put the order on hold.
So, I have refactor the Mass Order Unhold code to use Sales Order Interface as it is used or Mass Order Hold.

Manual testing scenarios

  1. Go to Sales Order Grid
  2. Select any number of holded orders to release hold
  3. Select Unhold from Action Dropdown

I have observed that MassAction Unhold is using the collection to release order from hold, whereas MassAction Hold is using Interface to put the order on hold.
So, I have refactor the Mass Order Unhold code to use Sales Order Interface as it is used or Mass Order Hold.
@sidolov
Copy link
Contributor

sidolov commented Apr 11, 2018

Closed as duplicate of #14629

@sidolov sidolov closed this Apr 11, 2018
@sidolov sidolov self-assigned this Apr 11, 2018
@magento magento deleted a comment from magento-engcom-team Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants