Skip to content

Commit bbbc0ac

Browse files
🔃 [Magento Community Engineering] Community Contributions - 2.4-develop expedited
Accepted Community Pull Requests: - #29054: Remove duplicated var customer.name from email template (by @ptylek) - #27516: [Fixed #26191] Need To Change Label In Totals Block in Order View Page (by @madhurajawat) - #28797: Fixed 'Undefined class constant' error when interceptor is generated. (by @vovayatsyuk) - #26660: Added The return of Post Value when an Integration Exception is thrown while Save Action (by @realadityayadav) - #29002: [MFTF] Use action group for QuickSearch (by @Usik2203) - #28955: [MFTF] use action group go to home page (by @Usik2203) - #28925: [MFTF] use action group for go to orders grid page (by @Usik2203) - #28839: Discount applying on Shipping Amount for the rule 'Buy X get Y free (discount amount is Y)' (by @engcom-Echo) - #28752: "Create Permanent Redirect for URLs if URL Key Changed" for categories (by @engcom-Charlie) - #28799: fix Rest-API updating product stock_item deletes downloadable product data (by @engcom-Charlie) - #28549: Cli config show returns `Configuration ... doesn't exist` if value is 0 or empty string (by @engcom-Charlie) - #28903: Create or update customer don't validate customer group id (by @engcom-Charlie) - #28959: [MFTF] use action group to click save button (by @Usik2203) - #28932: Implemented UrlFilterApplier component (by @gabrieldagama) - #28366: Fix Images in grid is not correctly aligned after clear filters (by @Nazar65) - #28749: Move localstorage polyfill to frontend (by @ihor-sviziev) Fixed GitHub Issues: - #29087: [Issue] Remove duplicated var customer.name from email template (reported by @m2-assistant[bot]) has been fixed in #29054 by @ptylek in 2.4-develop branch Related commits: 1. c9cc512 - #26191: Need To Change Label In Totals Block in Order View Page (reported by @nit-it) has been fixed in #27516 by @madhurajawat in 2.4-develop branch Related commits: 1. d3021f9 2. 012821a 3. 8c2159c 4. 6eae776 5. 02acf22 6. 7986ed6 7. f9d9f8d 8. 017102b 9. 8d952c3 10. 4e7d530 11. 8f73ab2 12. 1619403 13. 18cc491 14. 474232a 15. 79e1eb0 16. 5435634 17. d3dfc52 - #28981: [Issue] Fixed 'Undefined class constant' error when interceptor is generated. (reported by @m2-assistant[bot]) has been fixed in #28797 by @vovayatsyuk in 2.4-develop branch Related commits: 1. 54531b3 2. 1785136 3. 7620af2 4. dbad97b - #28143: [Issue] Added The return of Post Value when an Integration Exception is thrown while Save Action (reported by @m2-backlog[bot]) has been fixed in #26660 by @realadityayadav in 2.4-develop branch Related commits: 1. 4459cb0 2. bad241b 3. aa59c0b 4. 38bf16e 5. 04146b6 6. 59f031a 7. 29c7c90 8. f172e3c - #26723: Discount is not applying on Shipping Amount for the rule 'Buy X get Y free (discount amount is Y)'. (reported by @webkul-dhananjay) has been fixed in #28839 by @engcom-Echo in 2.4-develop branch Related commits: 1. 6005a92 2. ed1a21e 3. 3b33889 - #24922: "Create Permanent Redirect for URLs if URL Key Changed" for categories (reported by @vseager) has been fixed in #28752 by @engcom-Charlie in 2.4-develop branch Related commits: 1. 733d72a 2. 4592de4 3. a618259 4. efb73f7 5. 3cbe1ea 6. fbf5d3e 7. 0c9623a 8. b729b5a - #21811: Rest-API updating product stock_item deletes downloadable_product_links (reported by @EyalAmir) has been fixed in #28799 by @engcom-Charlie in 2.4-develop branch Related commits: 1. a09d71a 2. 7e6827d 3. c52c6e9 4. da41991 - #23290: ./bin/magento config:show returns "Configuration for path: '...' doesn't exist" if config value equals to 0 or empty string (reported by @OleksiiBulba) has been fixed in #28549 by @engcom-Charlie in 2.4-develop branch Related commits: 1. 3bff446 2. a6049d5 3. 70809f9 4. 655f5ab 5. 36ff6d7 6. 0ac7e12 - #28064: Web Api to create customer don't validate payload data and create corrupted record (reported by @GDauer) has been fixed in #28903 by @engcom-Charlie in 2.4-develop branch Related commits: 1. a16efb6 2. 7f8dd44 3. b0b6dc9 4. 616f082 5. 4ae198a 6. 360173a - #1501: magento2\lib\internal\Magento\Framework\Webapi\Rest\Request.php line:144 (reported by @zhaoxiong123) has been fixed in #28932 by @gabrieldagama in 2.4-develop branch Related commits: 1. be428f7 2. 984dab1 3. 5531f50 4. 1574740 5. 607aed6 6. 22c2be9 7. 58158aa 8. 1467c6e 9. 273607c 10. 8660c73 11. a8c3f67 12. 96e6752 13. c77d812 14. 03b3ef5 15. b4b16ff 16. 8af0f46 - #824: Unable to reindex from backend, bug? (reported by @MagePsycho) has been fixed in #28366 by @Nazar65 in 2.4-develop branch Related commits: 1. 8bfc104 2. a5a13fb 3. 5667714 4. a867d70 5. 1d0316d 6. d06fd27 7. f953f35 8. a0ed711 9. a63e681 10. 2133abc 11. 5032914 12. a548863 13. 6e8c990 14. aef54e3 - #972: Pub/Static directory is empty (reported by @mrugeshrocks) has been fixed in #28366 by @Nazar65 in 2.4-develop branch Related commits: 1. 8bfc104 2. a5a13fb 3. 5667714 4. a867d70 5. 1d0316d 6. d06fd27 7. f953f35 8. a0ed711 9. a63e681 10. 2133abc 11. 5032914 12. a548863 13. 6e8c990 14. aef54e3 - #28900: [Issue] Move localstorage polyfill to frontend (reported by @m2-assistant[bot]) has been fixed in #28749 by @ihor-sviziev in 2.4-develop branch Related commits: 1. 29b501a 2. cc01557
2 parents 1d8a6d7 + 79cdc2a commit bbbc0ac

File tree

149 files changed

+1789
-518
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

149 files changed

+1789
-518
lines changed

app/code/Magento/Backend/Test/Mftf/Test/AdminDashboardWithChartsTest.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,7 @@
9393
<see selector="{{AdminOrderDetailsMessagesSection.successMessage}}" userInput="The invoice has been created." stepKey="seeSuccessInvoiceMessage"/>
9494
<!--Create Shipment for the order-->
9595
<comment userInput="Create Shipment for the order" stepKey="createShipmentForOrder"/>
96-
<amOnPage url="{{AdminOrdersPage.url}}" stepKey="onOrdersPage2"/>
97-
<waitForPageLoad time="30" stepKey="waitForOrderListPageLoading"/>
96+
<actionGroup ref="AdminOrdersPageOpenActionGroup" stepKey="onOrdersPage2"/>
9897
<actionGroup ref="AdminOrderGridClickFirstRowActionGroup" stepKey="openOrderPageForShip"/>
9998
<click selector="{{AdminOrderDetailsMainActionsSection.ship}}" stepKey="clickShipAction"/>
10099
<waitForPageLoad stepKey="waitForShipmentPagePage"/>

app/code/Magento/Bundle/Test/Mftf/Test/AdminDeleteBundleDynamicProductTest.xml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,9 @@
4040
<amOnPage url="{{StorefrontProductPage.url($$createDynamicBundleProduct.name$$)}}" stepKey="amOnBundleProductPage"/>
4141
<see selector="{{StorefrontProductInfoMainSection.productName}}" userInput="Whoops, our bad..." stepKey="seeWhoops"/>
4242
<!-- Search for the product by sku -->
43-
<fillField selector="{{StorefrontQuickSearchSection.searchPhrase}}" userInput="$$createDynamicBundleProduct.sku$$" stepKey="fillSearchBarByProductSku"/>
44-
<waitForPageLoad stepKey="waitForSearchButton"/>
45-
<click selector="{{StorefrontQuickSearchSection.searchButton}}" stepKey="clickSearchButton"/>
46-
<waitForPageLoad stepKey="waitForSearchResults"/>
43+
<actionGroup ref="StoreFrontQuickSearchActionGroup" stepKey="searchByCreatedTerm">
44+
<argument name="query" value="$$createDynamicBundleProduct.sku$$"/>
45+
</actionGroup>
4746
<!-- Should not see any search results -->
4847
<dontSee userInput="$$createDynamicBundleProduct.sku$$" selector="{{StorefrontCatalogSearchMainSection.searchResults}}" stepKey="dontSeeProduct"/>
4948
<see selector="{{StorefrontCatalogSearchMainSection.message}}" userInput="Your search returned no results." stepKey="seeCantFindProductOneMessage"/>

app/code/Magento/Bundle/Test/Mftf/Test/AdminDeleteBundleFixedProductTest.xml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,9 @@
3737
<amOnPage url="{{StorefrontProductPage.url($$createFixedBundleProduct.name$$)}}" stepKey="amOnBundleProductPage"/>
3838
<see selector="{{StorefrontProductInfoMainSection.productName}}" userInput="Whoops, our bad..." stepKey="seeWhoops"/>
3939
<!-- Search for the product by sku -->
40-
<fillField selector="{{StorefrontQuickSearchSection.searchPhrase}}" userInput="$$createFixedBundleProduct.sku$$" stepKey="fillSearchBarByProductSku"/>
41-
<waitForPageLoad stepKey="waitForSearchButton"/>
42-
<click selector="{{StorefrontQuickSearchSection.searchButton}}" stepKey="clickSearchButton"/>
43-
<waitForPageLoad stepKey="waitForSearchResults"/>
40+
<actionGroup ref="StoreFrontQuickSearchActionGroup" stepKey="searchByCreatedTerm">
41+
<argument name="query" value="$$createFixedBundleProduct.sku$$"/>
42+
</actionGroup>
4443
<!-- Should not see any search results -->
4544
<dontSee userInput="$$createFixedBundleProduct.sku$$" selector="{{StorefrontCatalogSearchMainSection.searchResults}}" stepKey="dontSeeProduct"/>
4645
<see selector="{{StorefrontCatalogSearchMainSection.message}}" userInput="Your search returned no results." stepKey="seeCantFindProductOneMessage"/>
Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
9+
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
10+
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
11+
<actionGroup name="AdminProductFormSaveButtonClickActionGroup">
12+
<annotations>
13+
<description>Click Save button of product form.</description>
14+
</annotations>
15+
16+
<click selector="{{AdminProductFormSection.save}}" stepKey="clickSaveButton"/>
17+
<waitForPageLoad stepKey="waitForProductSaved"/>
18+
</actionGroup>
19+
</actionGroups>

app/code/Magento/Catalog/Test/Mftf/Section/AdminProductSEOSection.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
<element name="sectionHeader" type="button" selector="div[data-index='search-engine-optimization']" timeout="30"/>
1313
<element name="urlKeyInput" type="input" selector="input[name='product[url_key]']"/>
1414
<element name="useDefaultUrl" type="checkbox" selector="input[name='use_default[url_key]']"/>
15+
<element name="urlKeyRedirectCheckbox" type="checkbox" selector="input[name='product[url_key_create_redirect]']"/>
1516
<element name="metaTitleInput" type="input" selector="input[name='product[meta_title]']"/>
1617
<element name="metaKeywordsInput" type="textarea" selector="textarea[name='product[meta_keyword]']"/>
1718
<element name="metaDescriptionInput" type="textarea" selector="textarea[name='product[meta_description]']"/>

app/code/Magento/Catalog/Test/Mftf/Test/AdminCreateCustomProductAttributeWithDropdownFieldTest.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,7 @@
9494
<scrollToTopOfPage stepKey="scrollToTopOfPage"/>
9595
<click selector="{{AdminCreateNewProductAttributeSection.saveAttribute}}" stepKey="clickOnSaveAttribute"/>
9696
<waitForPageLoad stepKey="waitForAttributeToSave"/>
97-
<click selector="{{AdminProductFormSection.save}}" stepKey="saveTheProduct"/>
98-
<waitForPageLoad stepKey="waitForProductToSave"/>
97+
<actionGroup ref="AdminProductFormSaveButtonClickActionGroup" stepKey="saveTheProduct"/>
9998
<see selector="{{AdminCategoryMessagesSection.SuccessMessage}}" userInput="You saved the product." stepKey="messageYouSavedTheProductIsShown"/>
10099

101100
<!--Verify product attribute added in product form -->

app/code/Magento/Catalog/Test/Mftf/Test/AdminCreateProductAttributeFromProductPageTest.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,7 @@
8686
<scrollToTopOfPage stepKey="scrollToTopOfPage"/>
8787
<click selector="{{AdminCreateNewProductAttributeSection.saveAttribute}}" stepKey="clickOnSaveAttribute"/>
8888
<waitForPageLoad stepKey="waitForAttributeToSave"/>
89-
<click selector="{{AdminProductFormSection.save}}" stepKey="saveTheProduct"/>
90-
<waitForPageLoad stepKey="waitForProductToSave"/>
89+
<actionGroup ref="AdminProductFormSaveButtonClickActionGroup" stepKey="saveTheProduct"/>
9190
<see selector="{{AdminCategoryMessagesSection.SuccessMessage}}" userInput="You saved the product." stepKey="messageYouSavedTheProductIsShown"/>
9291

9392
<!--Run Re-Index task -->

app/code/Magento/Catalog/Test/Mftf/Test/AdminCreateProductAttributeRequiredTextFieldTest.xml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,7 @@
7474
<scrollToTopOfPage stepKey="scrollToTopOfPage"/>
7575
<click selector="{{AdminCreateNewProductAttributeSection.saveAttribute}}" stepKey="clickOnSaveAttribute"/>
7676
<waitForPageLoad stepKey="waitForAttributeToSave"/>
77-
<click selector="{{AdminProductFormSection.save}}" stepKey="saveTheProduct"/>
78-
<waitForPageLoad stepKey="waitForProductToSave"/>
77+
<actionGroup ref="AdminProductFormSaveButtonClickActionGroup" stepKey="saveTheProduct"/>
7978

8079
<!--Verify product attribute added in product form and Is Required message displayed-->
8180
<scrollTo selector="{{AdminProductFormSection.contentTab}}" stepKey="scrollToContentTab"/>
@@ -85,8 +84,7 @@
8584
<!--Fill the Required field and save the product -->
8685
<fillField selector="{{AdminProductFormSection.attributeRequiredInput(newProductAttribute.attribute_code)}}" userInput="attribute" stepKey="fillTheAttributeRequiredInputField"/>
8786
<scrollToTopOfPage stepKey="scrollToTopOfProductFormPage"/>
88-
<click selector="{{AdminProductFormSection.save}}" stepKey="saveTheProduct1"/>
89-
<waitForPageLoad stepKey="waitForProductToSave1"/>
87+
<actionGroup ref="AdminProductFormSaveButtonClickActionGroup" stepKey="saveTheProduct1"/>
9088
<see selector="{{AdminCategoryMessagesSection.SuccessMessage}}" userInput="You saved the product." stepKey="messageYouSavedTheProductIsShown"/>
9189
</test>
9290
</tests>

app/code/Magento/Catalog/Test/Mftf/Test/AdminCreateSimpleProductWithCountryOfManufactureAttributeSKUMaskTest.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,7 @@
4242
<fillField selector="{{AdminProductFormSection.productPrice}}" userInput="{{nameAndAttributeSkuMaskSimpleProduct.price}}" stepKey="fillSimpleProductPrice"/>
4343
<fillField selector="{{AdminProductFormSection.productWeight}}" userInput="{{nameAndAttributeSkuMaskSimpleProduct.weight}}" stepKey="fillSimpleProductWeight"/>
4444
<fillField selector="{{AdminProductFormSection.productQuantity}}" userInput="{{nameAndAttributeSkuMaskSimpleProduct.quantity}}" stepKey="fillSimpleProductQuantity"/>
45-
<click selector="{{AdminProductFormSection.save}}" stepKey="clickSaveButton"/>
46-
<waitForPageLoad stepKey="waitForSimpleProductToSave"/>
45+
<actionGroup ref="AdminProductFormSaveButtonClickActionGroup" stepKey="clickSaveButton"/>
4746
<!-- Verify customer see success message -->
4847
<see selector="{{AdminProductFormSection.successMessage}}" userInput="You saved the product." stepKey="seeAssertSimpleProductSaveSuccessMessage"/>
4948

app/code/Magento/Catalog/Test/Mftf/Test/AdminCreateVirtualProductFillingRequiredFieldsOnlyTest.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,7 @@
3434
<fillField selector="{{AdminProductFormSection.productName}}" userInput="{{virtualProductWithRequiredFields.name}}" stepKey="fillProductName"/>
3535
<fillField selector="{{AdminProductFormSection.productSku}}" userInput="{{virtualProductWithRequiredFields.sku}}" stepKey="fillProductSku"/>
3636
<fillField selector="{{AdminProductFormSection.productPrice}}" userInput="{{virtualProductWithRequiredFields.price}}" stepKey="fillProductPrice"/>
37-
<click selector="{{AdminProductFormSection.save}}" stepKey="clickSaveButton"/>
38-
<waitForPageLoad stepKey="waitForVirtualProductSaved" />
37+
<actionGroup ref="AdminProductFormSaveButtonClickActionGroup" stepKey="clickSaveButton"/>
3938

4039
<!-- Verify we see success message -->
4140
<see selector="{{AdminProductFormSection.successMessage}}" userInput="You saved the product." stepKey="seeAssertVirtualProductSuccessMessage"/>

app/code/Magento/Catalog/Test/Mftf/Test/AdminCreateVirtualProductOutOfStockWithTierPriceTest.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,7 @@
6161
<click selector="{{AdminProductSEOSection.sectionHeader}}" stepKey="clickAdminProductSEOSection"/>
6262
<fillField selector="{{AdminProductSEOSection.urlKeyInput}}" userInput="{{virtualProductOutOfStock.urlKey}}" stepKey="fillUrlKey"/>
6363
<scrollToTopOfPage stepKey="scrollToTopOfAdminProductFormSection"/>
64-
<click selector="{{AdminProductFormSection.save}}" stepKey="clickSaveButton"/>
65-
<waitForPageLoad stepKey="waitForVirtualProductSaved"/>
64+
<actionGroup ref="AdminProductFormSaveButtonClickActionGroup" stepKey="clickSaveButton"/>
6665

6766
<!-- Verify we see success message -->
6867
<see selector="{{AdminProductFormSection.successMessage}}" userInput="You saved the product." stepKey="seeAssertVirtualProductSuccessMessage"/>

app/code/Magento/Catalog/Test/Mftf/Test/AdminCreateVirtualProductWithCustomOptionsSuiteAndImportOptionsTest.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,7 @@
111111
<selectOption selector="{{AdminProductCustomizableOptionsSection.clickSelectPriceType(virtualProductCustomizableOption4.title,'1')}}" userInput="{{virtualProductCustomizableOption4.option_1_price_type}}" stepKey="selectOptionPriceTypeForFourthDataSetSecondRow"/>
112112
<fillField selector="{{AdminProductCustomizableOptionsSection.fillOptionValueSku(virtualProductCustomizableOption4.title,'1')}}" userInput="{{virtualProductCustomizableOption4.option_1_sku}}" stepKey="fillOptionSkuForFourthDataSetSecondRow"/>
113113
<scrollToTopOfPage stepKey="scrollToTopOfAdminProductFormSection"/>
114-
<click selector="{{AdminProductFormSection.save}}" stepKey="clickSaveButton"/>
115-
<waitForPageLoad stepKey="waitForVirtualProductSaved"/>
114+
<actionGroup ref="AdminProductFormSaveButtonClickActionGroup" stepKey="clickSaveButton"/>
116115

117116
<!-- Verify we see success message -->
118117
<see selector="{{AdminProductFormSection.successMessage}}" userInput="You saved the product." stepKey="seeAssertVirtualProductSuccessMessage"/>

app/code/Magento/Catalog/Test/Mftf/Test/AdminCreateVirtualProductWithTierPriceTest.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,7 @@
5353
<click selector="{{AdminProductSEOSection.sectionHeader}}" stepKey="clickAdminProductSEOSection"/>
5454
<fillField selector="{{AdminProductSEOSection.urlKeyInput}}" userInput="{{virtualProductBigQty.urlKey}}" stepKey="fillUrlKey"/>
5555
<scrollToTopOfPage stepKey="scrollToTopOfAdminProductFormSection"/>
56-
<click selector="{{AdminProductFormSection.save}}" stepKey="clickSaveButton"/>
57-
<waitForPageLoad stepKey="waitForVirtualProductSaved"/>
56+
<actionGroup ref="AdminProductFormSaveButtonClickActionGroup" stepKey="clickSaveButton"/>
5857

5958
<!-- Verify we see success message -->
6059
<see selector="{{AdminProductFormSection.successMessage}}" userInput="You saved the product." stepKey="seeAssertVirtualProductSuccessMessage"/>

app/code/Magento/Catalog/Test/Mftf/Test/AdminCreateVirtualProductWithoutManageStockTest.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,7 @@
5151
<click selector="{{AdminProductSEOSection.sectionHeader}}" stepKey="clickAdminProductSEOSection"/>
5252
<fillField selector="{{AdminProductSEOSection.urlKeyInput}}" userInput="{{virtualProductWithoutManageStock.urlKey}}" stepKey="fillUrlKey"/>
5353
<scrollToTopOfPage stepKey="scrollToTopOfAdminProductFormSection"/>
54-
<click selector="{{AdminProductFormSection.save}}" stepKey="clickSaveButton"/>
55-
<waitForPageLoad stepKey="waitForVirtualProductSaved"/>
54+
<actionGroup ref="AdminProductFormSaveButtonClickActionGroup" stepKey="clickSaveButton"/>
5655

5756
<!-- Verify we see success message -->
5857
<see selector="{{AdminProductFormSection.successMessage}}" userInput="You saved the product." stepKey="seeAssertVirtualProductSuccessMessage"/>

app/code/Magento/Catalog/Test/Mftf/Test/AdminDeleteProductWithCustomOptionTest.xml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,9 @@
3838
<amOnPage url="{{StorefrontProductPage.url($$createSimpleProduct.name$$)}}" stepKey="amOnSimpleProductPage"/>
3939
<see selector="{{StorefrontProductInfoMainSection.productName}}" userInput="Whoops, our bad..." stepKey="seeWhoops"/>
4040
<!-- Search for the product by sku -->
41-
<fillField selector="{{StorefrontQuickSearchSection.searchPhrase}}" userInput="$$createSimpleProduct.sku$$" stepKey="fillSearchBarByProductSku"/>
42-
<waitForPageLoad stepKey="waitForSearchButton"/>
43-
<click selector="{{StorefrontQuickSearchSection.searchButton}}" stepKey="clickSearchButton"/>
44-
<waitForPageLoad stepKey="waitForSearchResults"/>
41+
<actionGroup ref="StoreFrontQuickSearchActionGroup" stepKey="searchByCreatedTerm">
42+
<argument name="query" value="$$createSimpleProduct.sku$$"/>
43+
</actionGroup>
4544
<!-- Should not see any search results -->
4645
<dontSee userInput="$$createSimpleProduct.sku$$" selector="{{StorefrontCatalogSearchMainSection.searchResults}}" stepKey="dontSeeProduct"/>
4746
<see selector="{{StorefrontCatalogSearchMainSection.message}}" userInput="Your search returned no results." stepKey="seeCantFindProductOneMessage"/>

app/code/Magento/Catalog/Test/Mftf/Test/AdminDeleteSimpleProductTest.xml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,9 @@
3737
<amOnPage url="{{StorefrontProductPage.url($$createSimpleProduct.name$$)}}" stepKey="amOnSimpleProductPage"/>
3838
<see selector="{{StorefrontProductInfoMainSection.productName}}" userInput="Whoops, our bad..." stepKey="seeWhoops"/>
3939
<!-- Search for the product by sku -->
40-
<fillField selector="{{StorefrontQuickSearchSection.searchPhrase}}" userInput="$$createSimpleProduct.sku$$" stepKey="fillSearchBarByProductSku"/>
41-
<waitForPageLoad stepKey="waitForSearchButton"/>
42-
<click selector="{{StorefrontQuickSearchSection.searchButton}}" stepKey="clickSearchButton"/>
43-
<waitForPageLoad stepKey="waitForSearchResults"/>
40+
<actionGroup ref="StoreFrontQuickSearchActionGroup" stepKey="searchByCreatedTerm">
41+
<argument name="query" value="$$createSimpleProduct.sku$$"/>
42+
</actionGroup>
4443
<!-- Should not see any search results -->
4544
<dontSee userInput="$$createSimpleProduct.sku$$" selector="{{StorefrontCatalogSearchMainSection.searchResults}}" stepKey="dontSeeProduct"/>
4645
<see selector="{{StorefrontCatalogSearchMainSection.message}}" userInput="Your search returned no results." stepKey="seeCantFindProductOneMessage"/>

app/code/Magento/Catalog/Test/Mftf/Test/AdminDeleteVirtualProductTest.xml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,9 @@
3838
<amOnPage url="{{StorefrontProductPage.url($$createVirtualProduct.name$$)}}" stepKey="amOnVirtualProductPage"/>
3939
<see selector="{{StorefrontProductInfoMainSection.productName}}" userInput="Whoops, our bad..." stepKey="seeWhoops"/>
4040
<!-- Search for the product by sku -->
41-
<fillField selector="{{StorefrontQuickSearchSection.searchPhrase}}" userInput="$$createVirtualProduct.sku$$" stepKey="fillSearchBarByProductSku"/>
42-
<waitForPageLoad stepKey="waitForSearchButton"/>
43-
<click selector="{{StorefrontQuickSearchSection.searchButton}}" stepKey="clickSearchButton"/>
44-
<waitForPageLoad stepKey="waitForSearchResults"/>
41+
<actionGroup ref="StoreFrontQuickSearchActionGroup" stepKey="searchByCreatedTerm">
42+
<argument name="query" value="$$createVirtualProduct.sku$$"/>
43+
</actionGroup>
4544
<!-- Should not see any search results -->
4645
<dontSee userInput="$$createVirtualProduct.sku$$" selector="{{StorefrontCatalogSearchMainSection.searchResults}}" stepKey="dontSeeProduct"/>
4746
<see selector="{{StorefrontCatalogSearchMainSection.message}}" userInput="Your search returned no results." stepKey="seeCantFindProductOneMessage"/>

app/code/Magento/Catalog/Test/Mftf/Test/AdminMoveProductBetweenCategoriesTest.xml

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,7 @@
7878
<click selector="{{AdminProductFormSection.selectCategory(SimpleSubCategory.name)}}" stepKey="selectSub1Category"/>
7979
<click selector="{{AdminProductFormSection.done}}" stepKey="clickDone"/>
8080
<waitForPageLoad stepKey="waitForApplyCategory"/>
81-
<click selector="{{AdminProductFormSection.save}}" stepKey="clickSave"/>
82-
<waitForPageLoad stepKey="waitForSavingChanges"/>
81+
<actionGroup ref="AdminProductFormSaveButtonClickActionGroup" stepKey="clickSave"/>
8382

8483
<!-- Enable `Use Categories Path for Product URLs` on Stores -> Configuration -> Catalog -> Catalog -> Search Engine Optimization -->
8584
<amOnPage url="{{AdminCatalogSearchConfigurationPage.url}}" stepKey="onConfigPage"/>
@@ -109,8 +108,7 @@
109108
<checkOption selector="{{AdminProductFormSection.selectCategory($$createSecondCategory.name$$)}}" stepKey="selectCategory"/>
110109
<click selector="{{AdminProductFormSection.done}}" stepKey="pressButtonDone"/>
111110
<waitForPageLoad stepKey="waitForApplyCategory2"/>
112-
<click selector="{{AdminProductFormSection.save}}" stepKey="pushButtonSave"/>
113-
<waitForPageLoad stepKey="waitForSavingProduct"/>
111+
<actionGroup ref="AdminProductFormSaveButtonClickActionGroup" stepKey="pushButtonSave"/>
114112

115113
<!--Product is saved -->
116114
<see userInput="You saved the product." selector="{{CatalogProductsSection.messageSuccessSavedProduct}}" stepKey="seeSuccessMessage"/>
@@ -181,8 +179,7 @@
181179
<click selector="{{AdminProductFormSection.selectCategory({$grabNameSubCategory})}}" stepKey="selectSubCategory"/>
182180
<click selector="{{AdminProductFormSection.done}}" stepKey="clickButtonDone"/>
183181
<waitForPageLoad stepKey="waitForCategoryApply"/>
184-
<click selector="{{AdminProductFormSection.save}}" stepKey="clickButtonSave"/>
185-
<waitForPageLoad stepKey="waitForSaveChanges"/>
182+
<actionGroup ref="AdminProductFormSaveButtonClickActionGroup" stepKey="clickButtonSave"/>
186183

187184
<!-- Product is saved successfully -->
188185
<see userInput="You saved the product." selector="{{CatalogProductsSection.messageSuccessSavedProduct}}" stepKey="seeSaveMessage"/>

0 commit comments

Comments
 (0)