impr

Author: engcom-Charlie

app/code/Magento/Downloadable/Model/Link/UpdateHandler.php

@@ -36,6 +36,7 @@ public function __construct(LinkRepository $linkRepository)
      * @param object $entity
      * @param array $arguments
      * @return ProductInterface|object
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function execute($entity, $arguments = [])
     {

app/code/Magento/Downloadable/Model/Sample/UpdateHandler.php

@@ -36,6 +36,7 @@ public function __construct(SampleRepository $sampleRepository)
      * @param object $entity
      * @param array $arguments
      * @return ProductInterface|object
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function execute($entity, $arguments = [])
     {

dev/tests/api-functional/testsuite/Magento/Downloadable/Api/ProductRepositoryTest.php

@@ -8,29 +8,35 @@
 
 use Magento\Catalog\Api\Data\ProductInterface;
 use Magento\Framework\Api\ExtensibleDataInterface;
+use Magento\TestFramework\Helper\Bootstrap;
 use Magento\TestFramework\TestCase\WebapiAbstract;
 
 /**
  * Class ProductRepositoryTest for testing ProductRepository interface with Downloadable Product
  */
 class ProductRepositoryTest extends WebapiAbstract
 {
-    const SERVICE_NAME = 'catalogProductRepositoryV1';
-    const SERVICE_VERSION = 'V1';
-    const RESOURCE_PATH = '/V1/products';
-    const PRODUCT_SKU = 'sku-test-product-downloadable';
+    private const SERVICE_NAME = 'catalogProductRepositoryV1';
+    private const SERVICE_VERSION = 'V1';
+    private const RESOURCE_PATH = '/V1/products';
+    private const PRODUCT_SKU = 'sku-test-product-downloadable';
+
+    private const PRODUCT_SAMPLES = 'downloadable_product_samples';
+    private const PRODUCT_LINKS = 'downloadable_product_links';
 
     /**
      * @var string
      */
-    protected $testImagePath;
+    private $testImagePath;
 
+    /**
+     * @inheritdoc
+     */
     protected function setUp(): void
     {
-        parent::setUp();
-        $this->testImagePath = __DIR__ . DIRECTORY_SEPARATOR . '_files' . DIRECTORY_SEPARATOR . 'test_image.jpg';
+        $objectManager = Bootstrap::getObjectManager();
 
-        $objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager();
+        $this->testImagePath = __DIR__ . DIRECTORY_SEPARATOR . '_files' . DIRECTORY_SEPARATOR . 'test_image.jpg';
 
         /** @var DomainManagerInterface $domainManager */
         $domainManager = $objectManager->get(DomainManagerInterface::class);
@@ -45,7 +51,7 @@ protected function tearDown(): void
         $this->deleteProductBySku(self::PRODUCT_SKU);
         parent::tearDown();
 
-        $objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager();
+        $objectManager = Bootstrap::getObjectManager();
 
         /** @var DomainManagerInterface $domainManager */
         $domainManager = $objectManager->get(DomainManagerInterface::class);
@@ -303,26 +309,26 @@ public function testUpdateDownloadableProductLinks()
      */
     public function testUpdateDownloadableProductData(): void
     {
-        $this->createDownloadableProduct();
-        $extensionAttributes = ExtensibleDataInterface::EXTENSION_ATTRIBUTES_KEY;
+        $productResponce = $this->createDownloadableProduct();
+        $stockItemData = $productResponce[ProductInterface::EXTENSION_ATTRIBUTES_KEY]['stock_item'];
+
+        $stockItemData = TESTS_WEB_API_ADAPTER === self::ADAPTER_SOAP
+            ? $stockItemData['manage_stock'] = false
+            : ['stock_item' => ['manage_stock' => false]];
 
         $productData = [
             ProductInterface::SKU => self::PRODUCT_SKU,
-            ProductInterface::EXTENSION_ATTRIBUTES_KEY => [
-                'stock_item' => [
-                    'manage_stock' => false,
-                ],
-            ],
+            ProductInterface::EXTENSION_ATTRIBUTES_KEY => $stockItemData,
         ];
 
         $response = $this->saveProduct($productData);
 
-        $this->assertArrayHasKey(ExtensibleDataInterface::EXTENSION_ATTRIBUTES_KEY, $response);
-        $this->assertArrayHasKey('downloadable_product_samples', $response[$extensionAttributes]);
-        $this->assertArrayHasKey('downloadable_product_links', $response[$extensionAttributes]);
+        $this->assertArrayHasKey(ProductInterface::EXTENSION_ATTRIBUTES_KEY, $response);
+        $this->assertArrayHasKey(self::PRODUCT_SAMPLES, $response[ProductInterface::EXTENSION_ATTRIBUTES_KEY]);
+        $this->assertArrayHasKey(self::PRODUCT_LINKS, $response[ProductInterface::EXTENSION_ATTRIBUTES_KEY]);
 
-        $this->assertCount(2, $response[$extensionAttributes]['downloadable_product_samples']);
-        $this->assertCount(2, $response[$extensionAttributes]['downloadable_product_links']);
+        $this->assertCount(2, $response[ProductInterface::EXTENSION_ATTRIBUTES_KEY][self::PRODUCT_SAMPLES]);
+        $this->assertCount(2, $response[ProductInterface::EXTENSION_ATTRIBUTES_KEY][self::PRODUCT_LINKS]);
     }
 
     /**