Skip to content

Commit efb73f7

Browse files
fix enabled checkbox
1 parent a618259 commit efb73f7

File tree

2 files changed

+10
-8
lines changed
  • app/code/Magento/CatalogUrlRewrite

2 files changed

+10
-8
lines changed

app/code/Magento/CatalogUrlRewrite/Plugin/Catalog/Block/Adminhtml/Category/Tab/Attributes.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,10 @@ public function afterGetAttributesMeta(DataProvider $subject, $result)
6666
private function getUrlRewriteMeta(CategoryInterface $category): array
6767
{
6868
return [
69-
'value' => $category->getUrlKey(),
69+
'value' => $this->isSaveRewriteHistory($category->getStoreId()) ? $category->getUrlKey() : '',
7070
'valueMap' => [
71-
'true' => $this->isSaveRewriteHistory($category->getStoreId()) ? $category->getUrlKey() : false
71+
'false' => '',
72+
'true' => $category->getUrlKey()
7273
],
7374
'disabled' => true,
7475
];

app/code/Magento/CatalogUrlRewrite/Test/Unit/Plugin/Catalog/Block/Adminhtml/Category/Tab/AttributesTest.php

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -67,10 +67,11 @@ protected function setUp(): void
6767
* @dataProvider attributesMetaDataProvider
6868
*
6969
* @param bool $configEnabled
70-
* @param bool|string $expected
70+
* @param string $expectedValue
71+
* @param string $expectedValueMap
7172
* @return void
7273
*/
73-
public function testGetAttributesMeta(bool $configEnabled, $expected): void
74+
public function testGetAttributesMeta(bool $configEnabled, string $expectedValue, string $expectedValueMap): void
7475
{
7576
$this->categoryMock->expects($this->once())
7677
->method('getId')
@@ -93,11 +94,11 @@ public function testGetAttributesMeta(bool $configEnabled, $expected): void
9394
$this->assertArrayHasKey('url_key_create_redirect', $result);
9495

9596
$this->assertArrayHasKey('value', $result['url_key_create_redirect']);
96-
$this->assertEquals(self::STUB_URL_KEY, $result['url_key_create_redirect']['value']);
97+
$this->assertEquals($expectedValue, $result['url_key_create_redirect']['value']);
9798

9899
$this->assertArrayHasKey('valueMap', $result['url_key_create_redirect']);
99100
$this->assertArrayHasKey('true', $result['url_key_create_redirect']['valueMap']);
100-
$this->assertEquals($expected, $result['url_key_create_redirect']['valueMap']['true']);
101+
$this->assertEquals($expectedValueMap, $result['url_key_create_redirect']['valueMap']['true']);
101102

102103
$this->assertArrayHasKey('disabled', $result['url_key_create_redirect']);
103104
$this->assertTrue($result['url_key_create_redirect']['disabled']);
@@ -111,8 +112,8 @@ public function testGetAttributesMeta(bool $configEnabled, $expected): void
111112
public function attributesMetaDataProvider(): array
112113
{
113114
return [
114-
'save rewrite history config enabled' => [true, self::STUB_URL_KEY],
115-
'save rewrite history config disabled' => [false, false]
115+
'save rewrite history config enabled' => [true, self::STUB_URL_KEY, self::STUB_URL_KEY],
116+
'save rewrite history config disabled' => [false, '', 'url_key_777']
116117
];
117118
}
118119

0 commit comments

Comments
 (0)