Skip to content

MQE-2027: MFTF PHP Compatibility Update (PHP 7.4) #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 24, 2020
Merged

MQE-2027: MFTF PHP Compatibility Update (PHP 7.4) #684

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
849e5de
MQE-2027: MFTF PHP Compatibility Update (PHP 7.4)
jilu1 Apr 21, 2020
53944d4
Merge remote-tracking branch 'origin/MFTF3.0.0-RC2' into MQE-2027-2
jilu1 Apr 22, 2020
acba14c
Merge remote-tracking branch 'origin/MFTF3.0.0-RC2' into MQE-2027-2
jilu1 Apr 22, 2020
b66506c
MQE-2027: MFTF PHP Compatibility Update (PHP 7.4)
jilu1 Apr 22, 2020
3ad161b
MQE-2027: MFTF PHP Compatibility Update (PHP 7.4)
jilu1 Apr 23, 2020
e693222
MQE-2027: MFTF PHP Compatibility Update (PHP 7.4)
jilu1 Apr 24, 2020
1289e77
Merge branch 'MFTF3.0.0-RC2' into MQE-2027-2
jilu1 Apr 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
language: php
php:
- 7.3
- 7.4
services:
- docker
before_install:
Expand Down
3 changes: 2 additions & 1 deletion bin/functional
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
set -e

echo "==============================="
echo " EXECUTE DevDocsTest "
echo " EXECUTE Functional Tests "
echo "==============================="
bin/mftf build:project
bin/mftf run:test DevDocsTest -f
bin/mftf run:test FormatCurrencyTest -f
28 changes: 13 additions & 15 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,46 +9,44 @@
"sort-packages": true
},
"require": {
"php": "^7.3",
"php": "~7.3.0||~7.4.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put back constraint ^7.3 I intentionally added it to simplify future updates. ^ will allow any minor versions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change it for consistency. Isn't ~7.3.0 the same as ^7.3?
~7.3.0: >= 7.3.0 and < 7.4.0
^7.3: >= 7.3.0 and < 7.4

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really.
~7.3.0: >=7.3.0 and < 7.4.0
and
^7.3: >= 7.3.0 and < 8

"ext-curl": "*",
"ext-dom": "*",
"ext-json": "*",
"ext-openssl": "*",
"ext-intl": "*",
"allure-framework/allure-codeception": "~1.4.0",
"aws/aws-sdk-php": "^3.132",
"codeception/codeception": "~4.1.4",
"codeception/module-asserts": "^1.1",
"codeception/module-sequence": "^1.0",
"codeception/module-webdriver": "^1.0",
"composer/composer": "^1.6",
"composer/composer": "^1.9",
"csharpru/vault-php": "~3.5.3",
"csharpru/vault-php-guzzle6-transport": "^2.0",
"monolog/monolog": "^1.0",
"monolog/monolog": "^1.17",
"mustache/mustache": "~2.5",
"php-webdriver/webdriver": "^1.8.0",
"symfony/console": "^4.4",
"symfony/finder": "^4.4",
"symfony/finder": "^4.4||^5.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove 4.4 I think it's not necessary for us to support it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed. Will verify if it works

"symfony/mime": "^5.0",
"symfony/process": "^4.4",
"vlucas/phpdotenv": "^2.4"
},
"require-dev": {
"squizlabs/php_codesniffer": "~3.2",
"sebastian/phpcpd": "~5.0",
"brainmaestro/composer-git-hooks": "^2.3.1",
"doctrine/cache": "<1.7.0",
"codeception/aspect-mock": "^3.0",
"goaop/framework": "2.2.0",
"codacy/coverage": "^1.4",
"phpmd/phpmd": "^2.6.0",
"phpunit/phpunit": "^9",
"rregeer/phpunit-coverage-check": "^0.1.4",
"codeception/aspect-mock": "^3.0",
"doctrine/cache": "<1.7.0",
"goaop/framework": "~2.3.4",
"php-coveralls/php-coveralls": "^1.0",
"phpmd/phpmd": "^2.8.0",
"phpunit/phpunit": "~9.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set phpunit constraint to be ^9.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it since you are confident on it :)

"rregeer/phpunit-coverage-check": "^0.1.4",
"sebastian/phpcpd": "~5.0.0",
"squizlabs/php_codesniffer": "~3.5.4",
"symfony/stopwatch": "~3.4.6"
},
"suggest": {
"epfremme/swagger-php": "^2.0"
},
"replace": {
"facebook/webdriver": "^1.7.1"
},
Expand Down
Loading