MQE-2027: MFTF PHP Compatibility Update (PHP 7.4) #684
Conversation
# Conflicts: # composer.json # composer.lock
jilu1
force-pushed
the
MQE-2027-2
branch
3 times, most recently
from
318c38c to
7430748
Compare
- changed formatMoney to formatCurrency
composer.json
Outdated
| @@ -9,46 +9,44 @@ | |||
| "sort-packages": true | |||
| }, | |||
| "require": { | |||
| "php": "^7.3", | |||
| "php": "~7.3.0||~7.4.0", | |||
There was a problem hiding this comment.
Please put back constraint ^7.3 I intentionally added it to simplify future updates. ^ will allow any minor versions
There was a problem hiding this comment.
Change it for consistency. Isn't ~7.3.0 the same as ^7.3?
~7.3.0: >= 7.3.0 and < 7.4.0
^7.3: >= 7.3.0 and < 7.4
There was a problem hiding this comment.
Not really.
~7.3.0: >=7.3.0 and < 7.4.0
and
^7.3: >= 7.3.0 and < 8
composer.json
Outdated
| "mustache/mustache": "~2.5", | ||
| "php-webdriver/webdriver": "^1.8.0", | ||
| "symfony/console": "^4.4", | ||
| "symfony/finder": "^4.4", | ||
| "symfony/finder": "^4.4||^5.0", |
There was a problem hiding this comment.
Please remove 4.4 I think it's not necessary for us to support it.
There was a problem hiding this comment.
Changed. Will verify if it works
composer.json
Outdated
| "php-coveralls/php-coveralls": "^1.0", | ||
| "phpmd/phpmd": "^2.8.0", | ||
| "phpunit/phpunit": "~9.0.0", |
There was a problem hiding this comment.
Please set phpunit constraint to be ^9.0
There was a problem hiding this comment.
Changed it since you are confident on it :)
| @@ -2277,4 +2287,27 @@ private function hasDecimalPoint(string $outStr) | |||
| { | |||
| return strpos($outStr, localeconv()['decimal_point']) !== false; | |||
| } | |||
|
|
|||
| /** | |||
| * Parse userInput for formatCurrency action | |||
There was a problem hiding this comment.
I think this doc block is not covering full picture. I can see this method is is not attached to action name but rather for presence of specific fields in action.
- changed formatMoney to formatCurrency
- changed formatMoney to formatCurrency
Description
Fixed Issues (if relevant)
Contribution checklist