Skip to content

CreateData action must be able to parse Data entity which references another data #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 19, 2019
Merged

CreateData action must be able to parse Data entity which references another data #418

merged 7 commits into from
Aug 19, 2019

Conversation

okolesnyk
Copy link
Member

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@okolesnyk
Copy link
Member Author

https://m2build-ur.devops.magento.com/job/All-User-Requested-Tests/22799/
Success build

@soumyau soumyau self-requested a review August 13, 2019 15:59
@okolesnyk
MQE-1561: CreateData action must be able to parse Data entity which r…
37ea58d 
…eferences another data

- fix static check failures
@okolesnyk
MQE-1561: CreateData action must be able to parse Data entity which r…
32967a2 
…eferences another data

- fix regex to match all paths
@coveralls
Copy link

coveralls commented Aug 14, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.7%) to 52.176% when pulling 466f92c on MQE-1561 into a626fb8 on develop.

soumyau
soumyau suggested changes Aug 14, 2019
View reviewed changes
Copy link
Contributor

@soumyau soumyau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor remarks on method headers and exception handling. Rest looks good to me.

@okolesnyk
MQE-1561: CreateData action must be able to parse Data entity which r…
dd2da2e 
…eferences another data

- Added phpdoc blocks
soumyau
soumyau approved these changes Aug 16, 2019
View reviewed changes
Copy link
Contributor

@soumyau soumyau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review passed.

@KevinBKozan KevinBKozan merged commit 3a73b31 into develop Aug 19, 2019
@KevinBKozan KevinBKozan deleted the MQE-1561 branch December 12, 2019 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soumyau soumyau soumyau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@okolesnyk @coveralls @soumyau @KevinBKozan