Skip to content

Commit 8d07bec

Browse files
committed
MQE-1561: CreateData action must be able to parse Data entity which references another data
- fix static check failures
1 parent bec1456 commit 8d07bec

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

src/Magento/FunctionalTestingFramework/DataGenerator/Objects/EntityDataObject.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -82,14 +82,14 @@ class EntityDataObject
8282
/**
8383
* Constructor
8484
*
85-
* @param string $name
86-
* @param string $type
85+
* @param string $name
86+
* @param string $type
8787
* @param string[] $data
8888
* @param string[] $linkedEntities
8989
* @param string[] $uniquenessData
9090
* @param string[] $vars
91-
* @param string $parentEntity
92-
* @param string $filename
91+
* @param string $parentEntity
92+
* @param string $filename
9393
*/
9494
public function __construct(
9595
$name,

src/Magento/FunctionalTestingFramework/DataGenerator/Persist/OperationDataArrayResolver.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ public function resolveOperationDataArray($entityObject, $operationMetadata, $op
124124

125125
$dataReferenceResolver = new RuntimeDataReferenceResolver();
126126
foreach ($operationDataArray as $key => $operationDataValue) {
127-
if (is_array($operationDataValue)){
127+
if (is_array($operationDataValue)) {
128128
continue;
129129
}
130130
$operationDataArray[$key] = $dataReferenceResolver->getDataReference(

src/Magento/FunctionalTestingFramework/DataGenerator/Util/GenerationDataReferenceResolver.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,8 @@ public function getDataReference(string $data, string $originalDataEntity)
5757
*/
5858
public function getDataUniqueness(string $data, string $originalDataEntity)
5959
{
60-
preg_match(ActionObject::ACTION_ATTRIBUTE_VARIABLE_REGEX_PATTERN,
60+
preg_match(
61+
ActionObject::ACTION_ATTRIBUTE_VARIABLE_REGEX_PATTERN,
6162
$data,
6263
$matches
6364
);
@@ -74,7 +75,6 @@ public function getDataUniqueness(string $data, string $originalDataEntity)
7475
"Could not resolve entity reference \"{$matches['reference']}\" "
7576
. "in Data entity \"{$originalDataEntity}\""
7677
);
77-
7878
}
7979

8080
return $entityObject->getUniquenessDataByName($var);

src/Magento/FunctionalTestingFramework/DataGenerator/Util/RuntimeDataReferenceResolver.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,8 @@ public function getDataReference(string $data, string $originalDataEntity)
6363
*/
6464
public function getDataUniqueness(string $data, string $originalDataEntity)
6565
{
66-
preg_match(ActionObject::ACTION_ATTRIBUTE_VARIABLE_REGEX_PATTERN,
66+
preg_match(
67+
ActionObject::ACTION_ATTRIBUTE_VARIABLE_REGEX_PATTERN,
6768
$data,
6869
$matches
6970
);
@@ -80,7 +81,6 @@ public function getDataUniqueness(string $data, string $originalDataEntity)
8081
"Could not resolve entity reference \"{$matches['reference']}\" "
8182
. "in Data entity \"{$originalDataEntity}\""
8283
);
83-
8484
}
8585

8686
return $entityObject->getUniquenessDataByName($var);

0 commit comments

Comments
 (0)