Skip to content

MQE-1006: Handling secure/sensitive data in MFTF test #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 18, 2018
Merged

Conversation

imeron2433
Copy link
Contributor

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

aljcalandra and others added 15 commits June 6, 2018 16:14
Outside XML Elements

- Adding debug flag to generate tests
- Adding individual file validation for schema when debug is on
Outside XML Elements

- Abstracted validation code in Filesystem
Outside XML Elements

- Adding verification test for filesystem to check error
# Conflicts:
#	src/Magento/FunctionalTestingFramework/Config/Reader/Filesystem.php
#	src/Magento/FunctionalTestingFramework/Console/GenerateTestsCommand.php
- Added check for empty stepkey and unit test
Outside XML Elements

- Changed default verification tests to use debug turned off
- Added filename information for action groups actions as well
- Made error message slightly more specific
MQE-1017: Better Error Messaging When Non-Whitespace Characters Are Outside XML Elements
MQE-1021: Empty Action StepKey Attribute Issues
@coveralls
Copy link

coveralls commented Jun 18, 2018

Coverage Status

Coverage decreased (-0.2%) to 56.731% when pulling b2ee898 on develop into 659bf36 on MQE-1006.

@imeron2433 imeron2433 merged commit 4aad404 into MQE-1006 Jun 18, 2018
magento-devops-reposync-svc pushed a commit that referenced this pull request Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants