Skip to content

MQE-1017: Better Error Messaging When Non-Whitespace Characters Are Outside XML Elements #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 15, 2018
Merged

MQE-1017: Better Error Messaging When Non-Whitespace Characters Are Outside XML Elements #147

merged 7 commits into from
Jun 15, 2018

Conversation

aljcalandra
Copy link
Contributor

@aljcalandra aljcalandra commented Jun 13, 2018 •
edited
Loading

Description

When generate:tests is run with --debug information will be given as to what file these type of issues are occurring in.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@aljcalandra
MQE-1017: Better Error Messaging When Non-Whitespace Characters Are
596efbe 
Outside XML Elements

- Adding debug flag to generate tests
- Adding individual file validation for schema when debug is on
@aljcalandra
MQE-1017: Better Error Messaging When Non-Whitespace Characters Are
5afa47e 
Outside XML Elements

- Abstracted validation code in Filesystem
@aljcalandra
MQE-1017: Better Error Messaging When Non-Whitespace Characters Are
eac8f86 
Outside XML Elements

- Adding verification test for filesystem to check error
@aljcalandra
Merge branch 'develop' into MQE-1017
998e816 
# Conflicts:
#	src/Magento/FunctionalTestingFramework/Config/Reader/Filesystem.php
#	src/Magento/FunctionalTestingFramework/Console/GenerateTestsCommand.php
@aljcalandra
MQE-1017: Better Error Messaging When Non-Whitespace Characters Are
320e5d3 
Outside XML Elements

- Changed default verification tests to use debug turned off
@coveralls
Copy link

coveralls commented Jun 13, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 57.149% when pulling d06d9fb on MQE-1017 into c66df37 on develop.

@aljcalandra aljcalandra merged commit 98a3a7d into develop Jun 15, 2018
@aljcalandra aljcalandra deleted the MQE-1017 branch June 15, 2018 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aljcalandra @coveralls