Skip to content

Cut 0.0.99 #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 63 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,73 @@
# 0.0.99 - WIP
# 0.0.99 - 2021-07-09

## API Updates

* `lightning_block_sync::poll::Validate` is now public, allowing you to
implement the `lightning_block_sync::poll::Poll` trait without
`lightning_block_sync::poll::ChainPoller` (#956).
* `lightning::ln::peer_handler::PeerManager` no longer requires that no calls
are made to referencing the same `SocketDescriptor` after
`disconnect_socket` returns. This makes the API significantly less
deadlock-prone and simplifies `SocketDescriptor` implementations
significantly. The relevant changes have been made to `lightning_net_tokio`
and `PeerManager` documentation has been substantially rewritten (#957).
* `lightning::util::message_signing`'s `sign` and `verify` methods now take
secret and public keys by reference instead of value (#974).
* Substantially more information is now exposed about channels in
`ChannelDetails`. See documentation for more info (#984 and #988).
* The latest best block seen is now exposed in
`ChannelManager::current_best_block` and
`ChannelMonitor::current_best_block` (#984).
* Feerates charged when forwarding payments over channels is now set in
`ChannelConfig::fee_base_msat` when the channel is opened. For existing
channels, the value is set to the value provided in
`ChannelManagerReadArgs::default_config::channel_options` the first time the
`ChannelManager` is loaded in 0.0.99 (#975).
* We now reject HTLCs which are received to be forwarded over private channels
unless `UserConfig::accept_forwards_to_priv_channels` is set. Note that
`UserConfig` is never serialized and must be provided via
`ChannelManagerReadArgs::default_config` at each start (#975).

## Bug Fixes

* We now forward gossip messages to peers instead of only relaying
locally-generated gossip or sending gossip messages during initial sync
(#948).
* Correctly send `channel_update` messages to direct peers on private channels
(#949). Without this, a private node connected to an LDK node over a private
channel cannot receive funds as it does not know which fees the LDK node
will charge.
* `lightning::ln::channelmanager::ChannelManager` no longer expects to be
persisted spuriously after we receive a `channel_update` message about any
channel in the routing gossip (#972).
* Asynchronous `ChannelMonitor` updates (using the
`ChannelMonitorUpdateErr::TemporaryFailure` return variant) no longer cause
spurious HTLC forwarding failures (#954).
* Transaction provided via `ChannelMonitor::transactions_confirmed`
after `ChannelMonitor::best_block_updated` was called for a much later
block now trigger all relevant actions as of the later block. Previously
some transaction broadcasts or other responses required an additional
block be provided via `ChannelMonitor::best_block_updated` (#970).
* We no longer panic in rare cases when an invoice contained last-hop route
hints which were unusable (#958).

## Node Compatibility

* We now accept spurious `funding_locked` messages sent prior to
`channel_reestablish` messages after reconnect. This is a
[known, long-standing bug in lnd](https://github.com/lightningnetwork/lnd/issues/4006)
(#966).
* We now set the `first_blocknum` and `number_of_blocks` fields in
`reply_channel_range` messages to values which c-lightning versions prior to
0.10 accepted. This avoids spurious force-closes from such nodes (#961).

## Serialization Compatibility

* Due to a bug discovered in 0.0.98, if a `ChannelManager` is serialized on
version 0.0.98 while an `Event::PaymentSent` is pending processing, the
`ChannelManager` will fail to deserialize both on version 0.0.98 and later
versions. If you have such a `ChannelManager` available, a simple patch will
allow it to deserialize, please file an issue if you need assistance.
allow it to deserialize. Please file an issue if you need assistance (#973).

# 0.0.98 - 2021-06-11

Expand Down
8 changes: 4 additions & 4 deletions lightning-background-processor/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-background-processor"
version = "0.0.98"
version = "0.0.99"
authors = ["Valentine Wallace <vwallace@protonmail.com>"]
license = "MIT OR Apache-2.0"
repository = "http://github.com/rust-bitcoin/rust-lightning"
Expand All @@ -11,9 +11,9 @@ edition = "2018"

[dependencies]
bitcoin = "0.26"
lightning = { version = "0.0.98", path = "../lightning", features = ["allow_wallclock_use"] }
lightning-persister = { version = "0.0.98", path = "../lightning-persister" }
lightning = { version = "0.0.99", path = "../lightning", features = ["allow_wallclock_use"] }
lightning-persister = { version = "0.0.99", path = "../lightning-persister" }

[dev-dependencies]
lightning = { version = "0.0.98", path = "../lightning", features = ["_test_utils"] }
lightning = { version = "0.0.99", path = "../lightning", features = ["_test_utils"] }

4 changes: 2 additions & 2 deletions lightning-block-sync/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-block-sync"
version = "0.0.98"
version = "0.0.99"
authors = ["Jeffrey Czyz", "Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "http://github.com/rust-bitcoin/rust-lightning"
Expand All @@ -15,7 +15,7 @@ rpc-client = [ "serde", "serde_json", "chunked_transfer" ]

[dependencies]
bitcoin = "0.26"
lightning = { version = "0.0.98", path = "../lightning" }
lightning = { version = "0.0.99", path = "../lightning" }
tokio = { version = "1.0", features = [ "io-util", "net", "time" ], optional = true }
serde = { version = "1.0", features = ["derive"], optional = true }
serde_json = { version = "1.0", optional = true }
Expand Down
6 changes: 3 additions & 3 deletions lightning-invoice/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[package]
name = "lightning-invoice"
description = "Data structures to parse and serialize BOLT11 lightning invoices"
version = "0.6.0"
version = "0.7.0"
authors = ["Sebastian Geisler <sgeisler@wh2.tu-dresden.de>"]
documentation = "https://docs.rs/lightning-invoice/"
license = "MIT OR Apache-2.0"
Expand All @@ -10,10 +10,10 @@ readme = "README.md"

[dependencies]
bech32 = "0.7"
lightning = { version = "0.0.98", path = "../lightning" }
lightning = { version = "0.0.99", path = "../lightning" }
secp256k1 = { version = "0.20", features = ["recovery"] }
num-traits = "0.2.8"
bitcoin_hashes = "0.9.4"

[dev-dependencies]
lightning = { version = "0.0.98", path = "../lightning", features = ["_test_utils"] }
lightning = { version = "0.0.99", path = "../lightning", features = ["_test_utils"] }
4 changes: 2 additions & 2 deletions lightning-net-tokio/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-net-tokio"
version = "0.0.98"
version = "0.0.99"
authors = ["Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/rust-bitcoin/rust-lightning/"
Expand All @@ -12,7 +12,7 @@ edition = "2018"

[dependencies]
bitcoin = "0.26"
lightning = { version = "0.0.98", path = "../lightning" }
lightning = { version = "0.0.99", path = "../lightning" }
tokio = { version = "1.0", features = [ "io-util", "macros", "rt", "sync", "net", "time" ] }

[dev-dependencies]
Expand Down
6 changes: 3 additions & 3 deletions lightning-persister/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-persister"
version = "0.0.98"
version = "0.0.99"
authors = ["Valentine Wallace", "Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/rust-bitcoin/rust-lightning/"
Expand All @@ -13,11 +13,11 @@ unstable = ["lightning/unstable"]

[dependencies]
bitcoin = "0.26"
lightning = { version = "0.0.98", path = "../lightning" }
lightning = { version = "0.0.99", path = "../lightning" }
libc = "0.2"

[target.'cfg(windows)'.dependencies]
winapi = { version = "0.3", features = ["winbase"] }

[dev-dependencies]
lightning = { version = "0.0.98", path = "../lightning", features = ["_test_utils"] }
lightning = { version = "0.0.99", path = "../lightning", features = ["_test_utils"] }
2 changes: 1 addition & 1 deletion lightning/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning"
version = "0.0.98"
version = "0.0.99"
authors = ["Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/rust-bitcoin/rust-lightning/"
Expand Down