Skip to content

Cut 0.0.99 #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 9, 2021
Merged

Cut 0.0.99 #990

merged 2 commits into from
Jul 9, 2021

Conversation

TheBlueMatt
Copy link
Collaborator

This assumes #975 lands first.

@TheBlueMatt TheBlueMatt added this to the 0.0.99 milestone Jul 8, 2021
@codecov
Copy link

codecov bot commented Jul 8, 2021 •
edited
Loading

Codecov Report

Merging #990 (c9a8b26) into main (e04a1b3) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #990   +/-   ##
=======================================
  Coverage   90.76%   90.77%           
=======================================
  Files          60       60           
  Lines       30914    30914           
=======================================
+ Hits        28059    28061    +2     
+ Misses       2855     2853    -2
Impacted Files Coverage Δ
lightning/src/ln/functional_tests.rs 97.38% <0.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e04a1b3...c9a8b26. Read the comment docs.

ariard
ariard reviewed Jul 8, 2021
View reviewed changes
CHANGELOG.md Outdated
## Serialization Compatibility

* Due to a bug discovered in 0.0.98, if a `ChannelManager` is serialized on
version 0.0.98 while an `Event::PaymentSent` is pending processing, the
`ChannelManager` will fail to deserialize both on version 0.0.98 and later
versions. If you have such a `ChannelManager` available, a simple patch will
allow it to deserialize, please file an issue if you need assistance.
allow it to deserialize, please file an issue if you need assistance (#973).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should you mention edbc30c which is bumping chan's serialization ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, its fully backwards- and forwards-compatible. 0.0.98 can read versions written by 0.0.99 (though it ignores the fee info) and 0.0.99 can read versions written by 0.0.98.

jkczyz
jkczyz reviewed Jul 9, 2021
View reviewed changes
@TheBlueMatt TheBlueMatt force-pushed the 2021-07-0.0.99 branch 3 times, most recently from ea4862d to 11d4bb9 Compare July 9, 2021 14:03
jkczyz
jkczyz reviewed Jul 9, 2021
View reviewed changes
jkczyz
jkczyz reviewed Jul 9, 2021
View reviewed changes
jkczyz
jkczyz reviewed Jul 9, 2021
View reviewed changes
CHANGELOG.md Outdated
## Serialization Compatibility

* Due to a bug discovered in 0.0.98, if a `ChannelManager` is serialized on
version 0.0.98 while an `Event::PaymentSent` is pending processing, the
`ChannelManager` will fail to deserialize both on version 0.0.98 and later
versions. If you have such a `ChannelManager` available, a simple patch will
allow it to deserialize, please file an issue if you need assistance.
allow it to deserialize, please file an issue if you need assistance (#973).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like adding PR/issue numbers adds links

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, is it necessary? Its kinda annoying to have a million links in a plaintext document, and its not hard to load the PR from the number.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not necessary but I'd think it's less annoying since it is essentially write once, read many times.

@TheBlueMatt TheBlueMatt force-pushed the 2021-07-0.0.99 branch 2 times, most recently from 5fea2ad to 83110e3 Compare July 9, 2021 16:28
jkczyz
jkczyz approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@jkczyz jkczyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits.

CHANGELOG.md Outdated
## Serialization Compatibility

* Due to a bug discovered in 0.0.98, if a `ChannelManager` is serialized on
version 0.0.98 while an `Event::PaymentSent` is pending processing, the
`ChannelManager` will fail to deserialize both on version 0.0.98 and later
versions. If you have such a `ChannelManager` available, a simple patch will
allow it to deserialize, please file an issue if you need assistance.
allow it to deserialize, please file an issue if you need assistance (#973).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not necessary but I'd think it's less annoying since it is essentially write once, read many times.

valentinewallace
valentinewallace approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@valentinewallace valentinewallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK mod jeff's nits

@TheBlueMatt
Copy link
Collaborator Author

Fixed nits and squashed. Will take after CI:

$ git diff-tree -U1 83110e35 c9a8b26d
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 0fa93a84..764e2ffd 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,2 +1,2 @@
-# 0.0.99 - WIP
+# 0.0.99 - 2021-07-09
 
@@ -25,5 +25,5 @@
    `ChannelManager` is loaded in 0.0.99 (#975).
- * We now reject HTLCs which are received to be forwarded out over private
-   channels unless `UserConfig::accept_forwards_to_priv_channels` is set. Note
-   that `UserConfig` is never serialized and must be provided via
+ * We now reject HTLCs which are received to be forwarded over private channels
+   unless `UserConfig::accept_forwards_to_priv_channels` is set. Note that
+   `UserConfig` is never serialized and must be provided via
    `ChannelManagerReadArgs::default_config` at each start (#975).
@@ -69,3 +69,3 @@
    versions. If you have such a `ChannelManager` available, a simple patch will
-   allow it to deserialize, please file an issue if you need assistance (#973).
+   allow it to deserialize. Please file an issue if you need assistance (#973).

@TheBlueMatt TheBlueMatt merged commit afae12e into lightningdevkit:main Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ariard ariard ariard left review comments

@jkczyz jkczyz jkczyz approved these changes

@valentinewallace valentinewallace valentinewallace approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.0.99
Development

Successfully merging this pull request may close these issues.
4 participants
@TheBlueMatt @jkczyz @valentinewallace @ariard