Skip to content

[Splicing] Tx negotiation during splicing #3736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

[Splicing] Tx negotiation during splicing #3736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
07651d5
Rename DualFundingContext
optout21 Jun 3, 2025
d67d509
Extend begin_interactive_...() with splicing-specific parameters
optout21 Jun 3, 2025
0929b8b
fix Rename is_outbound to is_initiator
optout21 Jun 4, 2025
8fc11d9
Introduce NegotiatingChannelView to bridge Funded and PendingV2
optout21 Jun 3, 2025
e394081
fix More descriptive error messages in as_renegotiating_channel()
optout21 Jun 4, 2025
0d3329f
Implement transaction negotiation during splicing
optout21 Jun 3, 2025
a9ce424
fix Rename splice_init_checks to validate_splice_init
optout21 Jun 11, 2025
8ce5f29
fix Remove unneeded slight change to debug_assert
optout21 Jun 11, 2025
bcb9c6e
fix Smaller local code changes
optout21 Jun 4, 2025
d366251
fix Remove splice_init()/splice_ack() from Channel
optout21 Jun 5, 2025
4d5465f
fix Remove tx_*() methods from Channel
optout21 Jun 5, 2025
a568d5c
Cleanup: Remove splice_start() method
optout21 Jun 5, 2025
2f2146f
fix Build NegotiatingChannelView locally, to save an error check
optout21 Jun 5, 2025
baf5e7a
fix Comment on missing shared input, TODO
optout21 Jun 11, 2025
085cde7
fix Remove awaiting_splice_ack flag
optout21 Jun 5, 2025
9b3536b
fix Make splice_init_checks() not mut
optout21 Jun 5, 2025
c0a1536
fix Move funding_scope_for_splice() into FundingScope
optout21 Jun 5, 2025
5f32fd5
fix Never change is_outbound in FundingScope
optout21 Jun 11, 2025
1ff2b7d
fix Change unneeded assigns to asserts, in splice_ack
optout21 Jun 11, 2025
210d546
fix Simplification in funding_tx_constructed, use as_negotiating_channel
optout21 Jun 11, 2025
2e7f49b
fix Rename & comment calculate_total_funding_contribution
optout21 Jun 11, 2025
367593b
fix Close channel if splice msg is received while not funded
optout21 Jun 11, 2025
20233de
Add extra check on new funding, for invalid splice out
optout21 Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading