[Splicing] Tx negotiation during splicing #3736
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for assigning @wpaulino as a reviewer! |
This was referenced Apr 15, 2025
[Draft] RefundingChannel: combine FundedChannel and PendingV2Channel using a trait for Pending
#3720
Closed
optout21
force-pushed
the
splice-dual-tx4
branch
from
7f6dfbd to
c3778bc
Compare
1 similar comment
1 similar comment
1 similar comment
1 similar comment
1 similar comment
1 similar comment
wpaulino
reviewed
Apr 29, 2025
jkczyz
reviewed
Apr 29, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3736 +/- ##
==========================================
+ Coverage 89.73% 90.28% +0.55%
==========================================
Files 159 160 +1
Lines 128910 132032 +3122
Branches 128910 132032 +3122
==========================================
+ Hits 115676 119207 +3531
+ Misses 10536 10172 -364
+ Partials 2698 2653 -45 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
optout21
force-pushed
the
splice-dual-tx4
branch
3 times, most recently
from
88d2e83 to
866368d
Compare
|
Ready for a new round of review. I have addressed the comments, applied most of them. There is still one to-do (update channel reserve values), that I will do, but the rest is ready for review. |
|
Ready for a new round of review. All pending and newly raised comments addressed. |
wpaulino
reviewed
May 13, 2025
|
I'm working on shared input support, can be seen in draft PR #3842 . WIP. |
In begin_interactive_funding_tx_construction(), rename is_outbound to is_initiator, to prevent confusion with earlier the role at channel open.
Introduce struct NegotiatingChannelView to perform transaction negotiation logic, on top of both PendingV2Channel (dual-funded channel open) and FundedChannel (splicing).
Fill the logic for including transaction negotiation during splicing, implement the functions: splice_channel, splice_init, splice_ack, funding_tx_constructed. Also extend the test case test_v1_splice_in with the steps for funding negotiation during splicing.
optout21
force-pushed
the
splice-dual-tx4
branch
2 times, most recently
from
13321b2 to
cabd6be
Compare
ChannelTransactionParameters: clone only unchanged members. Optimize checking twice for pending_splice in splice_ack.
Add Channel.as_negotiating_channel(), and use that to call into the 5 tx_*() methods, so those could be removed from Channel.
optout21
force-pushed
the
splice-dual-tx4
branch
from
cabd6be to
de1b796
Compare
Instead, rely on the presense of the funding_scope and interactive_tx_constructor optional fields.
Simplify handling of pending_splice field check, get rid of one unwrap().
optout21
force-pushed
the
splice-dual-tx4
branch
from
de1b796 to
367593b
Compare
|
Comments addressed, summary of pending changes:
|
|
Let us know when this is ready for another round, no need to wait on #3842 to get more review on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of transaction negotiation during splicing.
Builds on 3407 and 3443.
Funded(FundedChannel)is used throughout splicingFundedChannelandPendingV2Channelcan act as a transaction constructorPendingV2Channellogic is put behind a trait --FundingTxConstructorV2RenegotiatingScopeis used to store extra state during splicingFundingChannelcan act as aFundingTxConstructorV2, using the state fromRenegotiatingScope(if present)FundedChannelandFundingTxConstructorhas context(), context accessors are extracted into a common base trait,ChannelContextProvider(it is also shared byInitialRemoteCommitmentReceiver).(Also relevant: #3444)