Skip to content

Cut 0.0.112 #1798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 25, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 61 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,64 @@
# 0.0.112 - XXX, 2022 - "XXX"

## API Updates
* `Result<(), ChannelMonitorUpdateErr>` return values have been replaced with
a `ChannelMonitorUpdateStatus` trinary enum. This better denotes that
`ChannelMonitorUpdateStatus::InProgress` is not an error, but asynchronous
persistence of a monitor update. Note that asynchronous persistence still
has some edge cases and is not yet recommended for production (#1106).
* `ChannelMonitor` persistence failure no longer automatically broadcasts the
latest commitment transaction. See the
`ChannelMonitorUpdateStatus::PermanentFailure` docs for more info (#1106).
* `*Features::known` has been replaced with individual
`*MessageHandler::provided_*_features` methods (#1707).
* `OnionMessenger` now takes a `CustomOnionMessageHandler` implementation,
allowing you to send and receive custom onion messages (#1748).
* `ProbabilisticScorer` now tracks the historical distribution of liquidity
estimates for channels. See new `historical_*` parameters in
`ProbabilisticScoringParameters` for more details (#1625).
* `lightning-block-sync`'s `BlockSource` trait now supports BIP 157/158
filtering clients by returning only header data for some blocks (#1706).
* `lightning-invoice`'s `Router` trait now accepts an `InFlightHtlcs` to
ensure we do not over-use a remote channel's funds during routing (#1694).
Note that this was previously backported to 0.0.111 for bindings users.
* `NetworkGraph::remove_stale_channels` has been renamed
`NetworkGraph::remove_stale_channels_and_tracking` as `NetworkGraph` now
refuses to re-add nodes and channels that were recently removed (#1649).
* The `lightning-rapid-gossip-sync` crate now supports `no-std` (#1708).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you may wanna point out that this was also backported

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, it was, but I'm not sure our typescript users even know what no-std is, or that they're using it lol

* The default `ProbabilisticScoringParameters::liquidity_offset_half_life` has
been increased to six hours from one (#1754).
* All commitment transaction building logic for anchor outputs now assumes the
no-HTLC-tx-fee variant (#1685).
* A number of missing `Eq` implementations were added (#1763).

## Bug Fixes
* `lightning-background-processor` now builds without error with the `futures`
feature (#1744).
* `ChannelManager::get_persistable_update_future`'s returned `Future` has been
corrected to not fail to be awoken in some cases (#1758).
* Asynchronously performing the initial `ChannelMonitor` persistence is now
safe (#1678).
* Redundantly applying rapid gossip sync updates no longer `Err`s (#1764).
* Nodes which inform us via payment failures that they should no longer be
used are now removed from the network graph. Some lnd nodes spuriously
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
used are now removed from the network graph. Some lnd nodes spuriously
used are now removed from the network graph. Some LND nodes spuriously

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it? I thought it was stylized lowercase. eg their readme mostly lists it as lnd - https://github.com/lightningnetwork/lnd/

Copy link
Contributor

@tnull tnull Oct 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I'm in favor of following a single writing style/english grammar rules whenever possible, i.e., capitalizing proper nouns and their abbreviations, independently of third parties' styling idiosyncrasies. Plus, I think almost every resource besides the Github README has it as "LND" (e.g., https://docs.lightning.engineering/), just as the logo does? If we want to stylize it as 'the binary'/'the shell command', it should be lnd at least.

🚲🏚

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷 I'm fine with whatever we want to do - no strong opinion.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to leave as is or to change. This def. should not block the release 😅

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I'm too lazy to wait for CI if I change it, then.

generate this error and may remove themselves from our graph (#1649).

In total, this release features 134 files changed, 6598 insertions, 4370
deletions in 109 commits from 13 authors, in alphabetical order:
* Duncan Dean
* Elias Rohrer
* Gabriel Comte
* Gursharan Singh
* Jeffrey Czyz
* Jurvis Tan
* Matt Corallo
* Max Fang
* Paul Miller
* Valentine Wallace
* Viktor Tigerström
* Wilmer Paulino
* acid-bit

# 0.0.111 - Sep 12, 2022 - "Saturated with Messages"

## API Updates
Expand Down
12 changes: 6 additions & 6 deletions lightning-background-processor/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-background-processor"
version = "0.0.111"
version = "0.0.112"
authors = ["Valentine Wallace <vwallace@protonmail.com>"]
license = "MIT OR Apache-2.0"
repository = "http://github.com/lightningdevkit/rust-lightning"
Expand All @@ -18,11 +18,11 @@ futures = [ "futures-util" ]

[dependencies]
bitcoin = "0.29.0"
lightning = { version = "0.0.111", path = "../lightning", features = ["std"] }
lightning-rapid-gossip-sync = { version = "0.0.111", path = "../lightning-rapid-gossip-sync" }
lightning = { version = "0.0.112", path = "../lightning", features = ["std"] }
lightning-rapid-gossip-sync = { version = "0.0.112", path = "../lightning-rapid-gossip-sync" }
futures-util = { version = "0.3", default-features = false, features = ["async-await-macro"], optional = true }

[dev-dependencies]
lightning = { version = "0.0.111", path = "../lightning", features = ["_test_utils"] }
lightning-invoice = { version = "0.19.0", path = "../lightning-invoice" }
lightning-persister = { version = "0.0.111", path = "../lightning-persister" }
lightning = { version = "0.0.112", path = "../lightning", features = ["_test_utils"] }
lightning-invoice = { version = "0.20.0", path = "../lightning-invoice" }
lightning-persister = { version = "0.0.112", path = "../lightning-persister" }
4 changes: 2 additions & 2 deletions lightning-block-sync/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-block-sync"
version = "0.0.111"
version = "0.0.112"
authors = ["Jeffrey Czyz", "Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "http://github.com/lightningdevkit/rust-lightning"
Expand All @@ -19,7 +19,7 @@ rpc-client = [ "serde", "serde_json", "chunked_transfer" ]

[dependencies]
bitcoin = "0.29.0"
lightning = { version = "0.0.111", path = "../lightning" }
lightning = { version = "0.0.112", path = "../lightning" }
futures-util = { version = "0.3" }
tokio = { version = "1.0", features = [ "io-util", "net", "time" ], optional = true }
serde = { version = "1.0", features = ["derive"], optional = true }
Expand Down
6 changes: 3 additions & 3 deletions lightning-invoice/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[package]
name = "lightning-invoice"
description = "Data structures to parse and serialize BOLT11 lightning invoices"
version = "0.19.0"
version = "0.20.0"
authors = ["Sebastian Geisler <sgeisler@wh2.tu-dresden.de>"]
documentation = "https://docs.rs/lightning-invoice/"
license = "MIT OR Apache-2.0"
Expand All @@ -21,14 +21,14 @@ std = ["bitcoin_hashes/std", "num-traits/std", "lightning/std", "bech32/std"]

[dependencies]
bech32 = { version = "0.9.0", default-features = false }
lightning = { version = "0.0.111", path = "../lightning", default-features = false }
lightning = { version = "0.0.112", path = "../lightning", default-features = false }
secp256k1 = { version = "0.24.0", default-features = false, features = ["recovery", "alloc"] }
num-traits = { version = "0.2.8", default-features = false }
bitcoin_hashes = { version = "0.11", default-features = false }
hashbrown = { version = "0.8", optional = true }
serde = { version = "1.0.118", optional = true }

[dev-dependencies]
lightning = { version = "0.0.111", path = "../lightning", default-features = false, features = ["_test_utils"] }
lightning = { version = "0.0.112", path = "../lightning", default-features = false, features = ["_test_utils"] }
hex = "0.4"
serde_json = { version = "1"}
4 changes: 2 additions & 2 deletions lightning-net-tokio/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-net-tokio"
version = "0.0.111"
version = "0.0.112"
authors = ["Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand All @@ -16,7 +16,7 @@ rustdoc-args = ["--cfg", "docsrs"]

[dependencies]
bitcoin = "0.29.0"
lightning = { version = "0.0.111", path = "../lightning" }
lightning = { version = "0.0.112", path = "../lightning" }
tokio = { version = "1.0", features = [ "io-util", "macros", "rt", "sync", "net", "time" ] }

[dev-dependencies]
Expand Down
6 changes: 3 additions & 3 deletions lightning-persister/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-persister"
version = "0.0.111"
version = "0.0.112"
authors = ["Valentine Wallace", "Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand All @@ -18,11 +18,11 @@ _bench_unstable = ["lightning/_bench_unstable"]

[dependencies]
bitcoin = "0.29.0"
lightning = { version = "0.0.111", path = "../lightning" }
lightning = { version = "0.0.112", path = "../lightning" }
libc = "0.2"

[target.'cfg(windows)'.dependencies]
winapi = { version = "0.3", features = ["winbase"] }

[dev-dependencies]
lightning = { version = "0.0.111", path = "../lightning", features = ["_test_utils"] }
lightning = { version = "0.0.112", path = "../lightning", features = ["_test_utils"] }
6 changes: 3 additions & 3 deletions lightning-rapid-gossip-sync/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning-rapid-gossip-sync"
version = "0.0.111"
version = "0.0.112"
authors = ["Arik Sosman <git@arik.io>"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning"
Expand All @@ -16,8 +16,8 @@ std = ["lightning/std"]
_bench_unstable = []

[dependencies]
lightning = { version = "0.0.111", path = "../lightning", default-features = false }
lightning = { version = "0.0.112", path = "../lightning", default-features = false }
bitcoin = { version = "0.29.0", default-features = false }

[dev-dependencies]
lightning = { version = "0.0.111", path = "../lightning", features = ["_test_utils"] }
lightning = { version = "0.0.112", path = "../lightning", features = ["_test_utils"] }
2 changes: 1 addition & 1 deletion lightning/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "lightning"
version = "0.0.111"
version = "0.0.112"
authors = ["Matt Corallo"]
license = "MIT OR Apache-2.0"
repository = "https://github.com/lightningdevkit/rust-lightning/"
Expand Down
2 changes: 2 additions & 0 deletions lightning/src/util/events.rs
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,7 @@ impl_writeable_tlv_based_enum_upgradable!(HTLCDestination,
}
);

#[cfg(anchors)]
/// A descriptor used to sign for a commitment transaction's anchor output.
#[derive(Clone, Debug)]
pub struct AnchorDescriptor {
Expand All @@ -224,6 +225,7 @@ pub struct AnchorDescriptor {
pub outpoint: OutPoint,
}

#[cfg(anchors)]
/// Represents the different types of transactions, originating from LDK, to be bumped.
#[derive(Clone, Debug)]
pub enum BumpTransactionEvent {
Expand Down