Cut 0.0.112 #1798
Cut 0.0.112 #1798
Conversation
This avoids adding unused, effectively-dummy public structs in `events.rs`.
| safe (#1678). | ||
| * Redundantly applying rapid gossip sync updates no longer `Err`s (#1764). | ||
| * Nodes which inform us via payment failures that they should no longer be | ||
| used are now removed from the network graph. Some lnd nodes spuriously |
There was a problem hiding this comment.
| used are now removed from the network graph. Some lnd nodes spuriously | |
| used are now removed from the network graph. Some LND nodes spuriously |
There was a problem hiding this comment.
Is it? I thought it was stylized lowercase. eg their readme mostly lists it as lnd - https://github.com/lightningnetwork/lnd/
There was a problem hiding this comment.
Well, I'm in favor of following a single writing style/english grammar rules whenever possible, i.e., capitalizing proper nouns and their abbreviations, independently of third parties' styling idiosyncrasies. Plus, I think almost every resource besides the Github README has it as "LND" (e.g., https://docs.lightning.engineering/), just as the logo does? If we want to stylize it as 'the binary'/'the shell command', it should be lnd at least.
🚲🏚
There was a problem hiding this comment.
🤷 I'm fine with whatever we want to do - no strong opinion.
There was a problem hiding this comment.
Feel free to leave as is or to change. This def. should not block the release 😅
There was a problem hiding this comment.
Okay, I'm too lazy to wait for CI if I change it, then.
Codecov ReportBase: 90.72% // Head: 90.73% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1798 +/- ##
==========================================
+ Coverage 90.72% 90.73% +0.01%
==========================================
Files 87 87
Lines 47374 47364 -10
Branches 47374 47364 -10
==========================================
- Hits 42979 42976 -3
+ Misses 4395 4388 -7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| * `NetworkGraph::remove_stale_channels` has been renamed | ||
| `NetworkGraph::remove_stale_channels_and_tracking` as `NetworkGraph` now | ||
| refuses to re-add nodes and channels that were recently removed (#1649). | ||
| * The `lightning-rapid-gossip-sync` crate now supports `no-std` (#1708). |
There was a problem hiding this comment.
you may wanna point out that this was also backported
There was a problem hiding this comment.
Yea, it was, but I'm not sure our typescript users even know what no-std is, or that they're using it lol
Some stuff ended up slipping, but I think its still worth shipping 0.0.112 with current git as-is.